Thread overview
[phobos] [Fwd: Re: [Fwd: Re: array appending changes to druntime]]
Feb 23, 2010
Walter Bright
Feb 23, 2010
Walter Bright
February 22, 2010
Thanks, but you've apparently added a function(s) that also need to be added to druntime/gcstub/gc.d

Steve Schveighoffer wrote:
> Not sure if you did it recently or not, but I do have commit access, thanks!
>
> I'll commit the patch shortly
>
> -Steve
>
>
>
> ----- Original Message ----
> 
>> From: Sean Kelly <sean at invisibleduck.org>
>> To: Steve Schveighoffer <schveiguy at yahoo.com>
>> Cc: Walter Bright <walter at digitalmars.com>
>> Sent: Mon, February 22, 2010 11:17:03 AM
>> Subject: Re: [Fwd: Re: [Fwd: Re: [phobos] array appending changes to druntime]]
>>
>> Oops!  I thought you had access already.  I'll look into it.
>>
>> On Feb 22, 2010, at 4:26 AM, Steve Schveighoffer wrote:
>>
>> 
>>> I have one -- schveiguy
>>>
>>> But I need access to druntime, not phobos (although I may need access to
>>> 
>> phobos to do other things).  I guess that would take Sean's approval.  I don't
>> mind helping out in druntime, but I'm not really any kind of expert on the
>> runtime, and I doubt I'll make many contributions besides this one without
>> assignment.  If Sean just wants to apply the patch, that is fine with me, but if
>> you want me to do it, that is fine too.
>> 
>>> -Steve
>>>
>>>
>>>
>>>
>>> ----- Original Message ----
>>> 
>>>> From: Walter Bright
>>>> To: Steve Schveighoffer
>>>> Sent: Sun, February 21, 2010 4:35:56 PM
>>>> Subject: [Fwd: Re: [Fwd: Re: [phobos] array appending changes to druntime]]
>>>>
>>>> I guess you need a dsource id!
>>>>
>>>> -------- Original Message --------
>>>> Subject:     Re: [Fwd: Re: [phobos] array appending changes to druntime]
>>>> Date:     Sun, 21 Feb 2010 13:25:37 -0800
>>>> From:     Brad Roberts
>>>> To:     Walter Bright
>>>> CC:     Brad Anderson
>>>> References:     <4B8180E8.6040304 at digitalmars.com>
>>>>
>>>>
>>>>
>>>> On dsource, go to the phobos project, click on the admin link.  On that page
>>>> 
>> is
>> 
>>>> a section for adding permissions.  You'll need his dsource id and to select a permission level, presumably developer.
>>>>
>>>> That should do it.
>>>>
>>>> On 2/21/2010 10:52 AM, Walter Bright wrote:
>>>> 
>>>>> Can we fix up Steve with Phobos commits? Thanks!
>>>>>
>>>>> -------- Original Message --------
>>>>> Subject:     Re: [phobos] array appending changes to druntime
>>>>> Date:     Sun, 21 Feb 2010 04:37:38 -0800 (PST)
>>>>> From:     Steve Schveighoffer
>>>>> Reply-To:     Discuss the phobos library for D
>>>>> To:     Discuss the phobos library for D
>>>>> References:     <4B7BB4E4.7020004 at digitalmars.com>
>>>>> <4B7C13CB.6010402 at erdani.com>
>>>>> <168314.40654.qm at web58002.mail.re3.yahoo.com>
>>>>> <4B7C4B3A.1040205 at erdani.com> <4B7C595A.9060700 at digitalmars.com>
>>>>>
>>>>> <486753.39390.qm at web58006.mail.re3.yahoo.com> <375362.78155.qm at web58006.mail.re3.yahoo.com> <4B80ACB0.5020200 at digitalmars.com>
>>>>>
>>>>>
>>>>>
>>>>> By "All Set" I meant that the patch is recreated against the current trunk and can be applied to druntime.  I don't have commit access, so I can't apply it.
>>>>>
>>>>> -Steve
>>>>>
>>>>>
>>>>>
>>>>> ----- Original Message ----
>>>>> 
>>>>>> From: Walter Bright
>>>>>> To: Discuss the phobos library for D
>>>>>> Sent: Sat, February 20, 2010 7:46:56 PM
>>>>>> Subject: Re: [phobos] array appending changes to druntime
>>>>>>
>>>>>>
>>>>>> 
>>>>> Steve Schveighoffer wrote:
>>>>> 
>>>>>> All set:
>>>>>>
>>>>>>
>>>>>>
>>>>>> 
>>>>> The changes don't seem to be checked in, this still
>>>>> 
>>>>>> fails:
>>>>>> 
>>>>> unittest {
>>>>> #line 950 "0350-arrays.tex"
>>>>> int[] a = [0, 10, 20,
>>>>> 
>>>>>> 30, 40, 50, 60, 70];
>>>>>> 
>>>>> auto b = a[4 .. $];
>>>>> a = a[0 .. 4];
>>>>> // At this
>>>>> 
>>>>>> point a and b are adjacent
>>>>>> 
>>>>> a ~= [0, 0, 0, 0];
>>>>> assert(b == [40, 50, 60,
>>>>> 
>>>>>> 70]); // passes; a got reallocated
>>>>>> 
>>>>> }
>>>>>
>>>>> void
>>>>> 
>>>>>> main(){}
>>>>>> 
>>>>> _______________________________________________
>>>>> phobos mailing
>>>>> 
>>>>>> list
>>>>>> href="mailto:phobos at puremagic.com">phobos at puremagic.com
>>>>>> 
>>>>> http://lists.puremagic.com/mailman/listinfo/phobos
>>>>>
>>>>>
>>>>>     _______________________________________________
>>>>> phobos mailing list
>>>>> phobos at puremagic.com
>>>>> http://lists.puremagic.com/mailman/listinfo/phobos
>>>>>
>>>>>
>>>>> 
>>>
>>>
>>> 
>
>
>
> 
>
>
> 
February 22, 2010
Eh, fixed it. Nevermind!

Walter Bright wrote:
> Thanks, but you've apparently added a function(s) that also need to be added to druntime/gcstub/gc.d
>
February 23, 2010
Yes, I did not update gcstub.  Thanks for fixing that.

-Steve



----- Original Message ----
> From: Walter Bright <walter at digitalmars.com>
> To: Discuss the phobos library for D <phobos at puremagic.com>
> Sent: Mon, February 22, 2010 11:53:05 PM
> Subject: Re: [phobos] [Fwd: Re: [Fwd: Re: array appending changes to druntime]]
> 
> Eh, fixed it. Nevermind!
> 
> Walter Bright wrote:
> > Thanks, but you've apparently added a function(s) that also need to be added
> to druntime/gcstub/gc.d
> > 
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos