http://d.puremagic.com/issues/show_bug.cgi?id=9269

           Summary: [2.061] rdmd -unittest fails with lcurl not found
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Phobos
        AssignedTo: nobody@puremagic.com
        ReportedBy: philippe.sigaud@gmail.com


--- Comment #0 from Philippe Sigaud <philippe.sigaud@gmail.com> 2013-01-04 16:09:57 CET ---
DMD 2.061:

A std.traits unit test has a pragma(lib, "curl") declaration. That makes

$ rdmd -unittest myfile.d

fail because dmd -deps (called by rdmd) activate the pragma and if the user has no curl installed, this stops the compilation.

Btw,

$ dmd -unittest myfile.d

works OK.

The concerned std.traits unit test should be changed.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=9269


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrej.mitrovich@gmail.com


--- Comment #1 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-01-04 08:08:41 PST ---
*** Issue 9007 has been marked as a duplicate of this issue. ***

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=9269


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pisetta.gianni@alice.it


--- Comment #2 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-01-18 10:19:57 PST ---
*** Issue 9349 has been marked as a duplicate of this issue. ***

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=9269



--- Comment #3 from Gianni Pisetta <pisetta.gianni@alice.it> 2013-01-21 11:16:57 PST ---
Created an attachment (id=1181)
patch to std.traits.d file for eliminating the dependency over libcurl

Patch that solves the issue of libcurl needed in the unittest of std.traits module replacing the tests with the core.sync.barrier module.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=9269



--- Comment #4 from Gianni Pisetta <pisetta.gianni@alice.it> 2013-01-21 11:22:41 PST ---
I tought that it is incorrect to use a module that needs an external library,
so i replaced the use of etc.c.curl module with the core.sync.barrier module,
that doesn't need other libraries and i think it is unlikely that that module
is changed in the future.
I have attached the patch file generated with diff.

Gianni Pisetta

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=9269



--- Comment #5 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-01-21 11:35:45 PST ---
(In reply to comment #3)
> Created an attachment (id=1181) [details]
> patch to std.traits.d file for eliminating the dependency over libcurl
> 
> Patch that solves the issue of libcurl needed in the unittest of std.traits module replacing the tests with the core.sync.barrier module.

Thanks. Do you want to make a pull request or should we do it for you?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=9269



--- Comment #6 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-01-21 17:27:00 PST ---
https://github.com/D-Programming-Language/phobos/pull/1088

Thanks again Gianni.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=9269



--- Comment #7 from github-bugzilla@puremagic.com 2013-01-21 18:44:18 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/40d9ebcdfb061856ae89ecbc8c1b723b4d63d8f3 Fixes Issue 9269 - Remove import to curl to avoid unittest build failure.

https://github.com/D-Programming-Language/phobos/commit/1ec2e521b2fb328da8faddfa1e0edd940ed2cf5c Merge pull request #1088 from AndrejMitrovic/Fix9269

Issue 9269 - Remove import to curl to avoid unittest build failure

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=9269


yebblies <yebblies@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yebblies@gmail.com


--- Comment #8 from yebblies <yebblies@gmail.com> 2013-01-22 15:07:32 EST ---
Fixed?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=9269


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME


--- Comment #9 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-01-25 15:29:08 PST ---
Should be fixed. Reopen if necessary.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------