I think this bug report can just be closed:

https://issues.dlang.org/show_bug.cgi?id=9889

The example works fine.

Its also confusing because the comment says std.format.formatValue, but the code uses std.string.format.

On a side note, as if I find old bug reports that can just be closed whats the best way for me to report it?

If I add a comment on the bug report will it just be lost in the shuffle?

-Andy

AndyC:

> On a side note, as if I find old bug reports that can just be closed whats the best way for me to report it?

You can add a comment to the issue.

Bye,
bearophile

On Saturday, 24 January 2015 at 14:12:00 UTC, AndyC wrote:
> On a side note, as if I find old bug reports that can just be closed whats the best way for me to report it?
>
> If I add a comment on the bug report will it just be lost in the shuffle?

You can close them yourself. You don't need special privileges for that.

If the issue has been fixed and you know the corresponding commit/PR, close as FIXED, and add a link to the fix on GitHub.

If the test case passes but you don't know what fixed it, close as WORKSFORME.

Of course, don't close if it could be a platform specific issue; do ask the submitter to test again before closing; etc. That is, apply common sense.

Also be aware that tests that failed at some point can be valuable additions to the code base to avoid regressions.

"AndyC"  wrote in message news:fsmjexsfxtqveqffiemc@forum.dlang.org...

> I think this bug report can just be closed:
>
> https://issues.dlang.org/show_bug.cgi?id=9889
>
> The example works fine.

It still fails on win32.

> Its also confusing because the comment says std.format.formatValue, but the code uses std.string.format.

std.string.format uses formatValue internally.

> On a side note, as if I find old bug reports that can just be closed whats the best way for me to report it?

I usually post a comment if I can't reproduce, and wait for the original author to confirm that it has been fixed.  Be careful about which platform it was reported for and which one you're testing on.  Some bugs can obviously be closed, such as those that deal with features that have been removed.

> If I add a comment on the bug report will it just be lost in the shuffle?

Yes and no.  A comment may not get much attention, but some of us do read through all the bug updates, and a comment about failure to reproduce or a question about validity will likely get answered eventually. 

On Saturday, 24 January 2015 at 17:11:41 UTC, anonymous wrote:
> If the test case passes but you don't know what fixed it, close as WORKSFORME.

If you wish, you can use Digger to find the pull request which fixed the bug, by doing a reverse bisection.

On Saturday, 24 January 2015 at 17:13:19 UTC, Daniel Murphy wrote:
> "AndyC"  wrote in message news:fsmjexsfxtqveqffiemc@forum.dlang.org...
>
>> I think this bug report can just be closed:
>>
>> https://issues.dlang.org/show_bug.cgi?id=9889
>>
>> The example works fine.
>
> It still fails on win32.
>

Oops, I should not have assumed format was os independent.


On a side note, I assume D1 is EOL'd and I can close bugs like this one?

https://issues.dlang.org/show_bug.cgi?id=6450


On a side-side note, is it ok if I close the low hanging fruit?

-Andy

"AndyC"  wrote in message news:vbenmvhfimpisqmudpbj@forum.dlang.org...

> On a side note, I assume D1 is EOL'd and I can close bugs like this one?
>
> https://issues.dlang.org/show_bug.cgi?id=6450

Unfortunately no.  While D1 is not being officially released any more, Walter is still supporting it for sociomantic and the bugs are still useful. It's only getting maintenance work, so large enhancement requests can usually be closed as WONTFIX, but ices/wrong-code should be kept for now.

Also, just because it's marked as version D1 doesn't mean it doesn't apply to D2 as well.  If you can verify that it doesn't happen for D2 it's helpful to prefix "(D1 only)" to the title.

> On a side-side note, is it ok if I close the low hanging fruit?

I don't know what you mean, you'll have to be more specific. 

On Sunday, 25 January 2015 at 03:16:32 UTC, Daniel Murphy wrote:
> "AndyC"  wrote in message news:vbenmvhfimpisqmudpbj@forum.dlang.org...
>

>
>> On a side-side note, is it ok if I close the low hanging fruit?
>
> I don't know what you mean, you'll have to be more specific.

I mean the really old reports, that are obviously no longer an issue (depricated units, fixed, bad report, etc)

like these:

https://issues.dlang.org/show_bug.cgi?id=4718
https://issues.dlang.org/show_bug.cgi?id=4310
https://issues.dlang.org/show_bug.cgi?id=2116

-Andy

"AndyC"  wrote in message news:dfqsgnkuimlxvsotppwk@forum.dlang.org... 

> I mean the really old reports, that are obviously no longer an issue (depricated units, fixed, bad report, etc)
> 
> like these:
> 
> https://issues.dlang.org/show_bug.cgi?id=4718
> https://issues.dlang.org/show_bug.cgi?id=4310
> https://issues.dlang.org/show_bug.cgi?id=2116

Sure.