Thread overview | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
September 02, 2015 [Issue 15000] Changes to userShell either need to be reverted or the std.process documentation needs to be updated | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=15000 Jonathan M Davis <issues.dlang@jmdavisProg.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Chanegs to userShell either |Changes to userShell either |need to be reverted or the |need to be reverted or the |std.process documentation |std.process documentation |needs to be updated |needs to be updated -- |
September 02, 2015 [Issue 15000] Changes to userShell either need to be reverted or the std.process documentation needs to be updated | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=15000 Vladimir Panteleev <thecybershadow@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thecybershadow@gmail.com --- Comment #1 from Vladimir Panteleev <thecybershadow@gmail.com> --- Congratulations on filing issue 15000. (In reply to Jonathan M Davis from comment #0) > 2. Change userShell back so that it actually returns the user's shell and not always /bin/sh but change spawnShell/executeShell to explicitly use /bin/sh or create some other, private helper function similar to userShell which returns the system's shell but not the necessarily the user's shell. This seems to be the correct solution to me. -- |
September 02, 2015 [Issue 15000] Changes to userShell either need to be reverted or the std.process documentation needs to be updated | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=15000 --- Comment #2 from Jonathan M Davis <issues.dlang@jmdavisProg.com> --- (In reply to Vladimir Panteleev from comment #1) > Congratulations on filing issue 15000. LOL. It's crazy how high the bug numbers are getting. More than 11,000 issues have been filed since the first one I filed... -- |
September 03, 2015 [Issue 15000] Changes to userShell either need to be reverted or the std.process documentation needs to be updated | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=15000 Vladimir Panteleev <thecybershadow@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |pull See Also| |https://issues.dlang.org/sh | |ow_bug.cgi?id=14282 --- Comment #3 from Vladimir Panteleev <thecybershadow@gmail.com> --- https://github.com/D-Programming-Language/phobos/pull/3629 -- |
September 03, 2015 [Issue 15000] Changes to userShell either need to be reverted or the std.process documentation needs to be updated | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=15000 --- Comment #4 from Vladimir Panteleev <thecybershadow@gmail.com> --- (In reply to Jonathan M Davis from comment #0) > The change to userShell did break one of my programs (the one I used to build dmd, druntime, and Phobos actually), and someone else in D.Learn ran afoul of the change: > > http://forum.dlang.org/post/ozueqlrtifopffmumbcl@forum.dlang.org I should add that option 2 is not going to fix these. But although option 1 (revert the change) would fix these programs, I'd argue that these programs are incorrect. If the user's SHELL was set to a bash-incompatible shell, these programs will fail. Also, option 2 (which is what the PR above does) removes all *uses* of userShell on POSIX from std.process, essentially reserving it for use by D users (e.g. if they want to start the machine user's preferred shell). -- |
September 03, 2015 [Issue 15000] Changes to userShell either need to be reverted or the std.process documentation needs to be updated | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=15000 --- Comment #5 from github-bugzilla@puremagic.com --- Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/f537cb50b5f8f9ad6d841db14b2e0a6cb845d008 fix Issue 15000 - Changes to userShell either need to be reverted or the std.process documentation needs to be updated https://github.com/D-Programming-Language/phobos/commit/88fc63d8d3d47ded732e801d4ccacec21eccb8f2 Merge pull request #3629 from CyberShadow/pull-20150903-114509-issue-15000 fix Issue 15000 - Changes to userShell either need to be reverted or … -- |
September 03, 2015 [Issue 15000] Changes to userShell either need to be reverted or the std.process documentation needs to be updated | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=15000 github-bugzilla@puremagic.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- |
October 04, 2015 [Issue 15000] Changes to userShell either need to be reverted or the std.process documentation needs to be updated | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=15000 --- Comment #6 from github-bugzilla@puremagic.com --- Commits pushed to stable at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/f537cb50b5f8f9ad6d841db14b2e0a6cb845d008 fix Issue 15000 - Changes to userShell either need to be reverted or the std.process documentation needs to be updated https://github.com/D-Programming-Language/phobos/commit/88fc63d8d3d47ded732e801d4ccacec21eccb8f2 Merge pull request #3629 from CyberShadow/pull-20150903-114509-issue-15000 -- |
Copyright © 1999-2021 by the D Language Foundation