Thread overview
[Issue 6607] critical_.d and critical.c use double check locking the wrong way
May 20, 2015
Martin Nowak
Jun 18, 2015
deadalnix
November 18, 2014
https://issues.dlang.org/show_bug.cgi?id=6607

hsteoh@quickfur.ath.cx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hsteoh@quickfur.ath.cx

--
November 25, 2014
https://issues.dlang.org/show_bug.cgi?id=6607

hsteoh@quickfur.ath.cx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|hsteoh@quickfur.ath.cx      |

--
May 20, 2015
https://issues.dlang.org/show_bug.cgi?id=6607

Martin Nowak <code@dawg.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |code@dawg.eu

--- Comment #3 from Martin Nowak <code@dawg.eu> ---
How ludicrous to have a known race condition in synchronized and not fixing it for 3 years.

--
May 20, 2015
https://issues.dlang.org/show_bug.cgi?id=6607

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--
May 20, 2015
https://issues.dlang.org/show_bug.cgi?id=6607

--- Comment #4 from github-bugzilla@puremagic.com ---
Commit pushed to master at https://github.com/D-Programming-Language/druntime

https://github.com/D-Programming-Language/druntime/commit/0b41a6205361382930272813a5f6a2baae0c456a cleanup and rewrite rt.critical_

- reuse mutex declarations from rt.monitor_
- fix race condition (incorrect double checked locking)
- modernize code for readability
- use shared(D_CRITICAL_SECTION)* when dealing with
  unsynchronized data
- replace STI/STD style C constructors
- fix Issue 6607
- hopefully fix Issue 14584 - spurious autotester deadlocks

--
June 17, 2015
https://issues.dlang.org/show_bug.cgi?id=6607

--- Comment #5 from github-bugzilla@puremagic.com ---
Commit pushed to stable at https://github.com/D-Programming-Language/druntime

https://github.com/D-Programming-Language/druntime/commit/0b41a6205361382930272813a5f6a2baae0c456a cleanup and rewrite rt.critical_

--
June 18, 2015
https://issues.dlang.org/show_bug.cgi?id=6607

--- Comment #6 from deadalnix <deadalnix@gmail.com> ---
Thumb up !

--
July 19, 2017
https://issues.dlang.org/show_bug.cgi?id=6607

--- Comment #7 from github-bugzilla@puremagic.com ---
Commit pushed to dmd-cxx at https://github.com/dlang/druntime

https://github.com/dlang/druntime/commit/0b41a6205361382930272813a5f6a2baae0c456a cleanup and rewrite rt.critical_

--