https://issues.dlang.org/show_bug.cgi?id=12558

Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|try/catch allows implicit   |try/catch allows implicit
                   |catching of Throwables      |catching of Errors without
                   |without specifying any      |specifying any Exception
                   |Exception type              |type

--- Comment #8 from Andrej Mitrovic <andrej.mitrovich@gmail.com> ---
Edited title to refer to Errors rather than Throwables, since that's the actual problematic part.

--

https://issues.dlang.org/show_bug.cgi?id=12558

Martin Nowak <code@dawg.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |code@dawg.eu

--- Comment #9 from Martin Nowak <code@dawg.eu> ---
So, anyone wants to implement the compiler warning to start deprecating this?

--

https://issues.dlang.org/show_bug.cgi?id=12558

--- Comment #10 from Vladimir Panteleev <thecybershadow@gmail.com> ---
The pull request exists, Andrej filed it in the URL field:

https://github.com/D-Programming-Language/dmd/pull/3482

--

https://issues.dlang.org/show_bug.cgi?id=12558

--- Comment #11 from Vladimir Panteleev <thecybershadow@gmail.com> ---
(In reply to Vladimir Panteleev from comment #10)
> The pull request exists, Andrej filed it in the URL field:
> 
> https://github.com/D-Programming-Language/dmd/pull/3482

This pull request now has conflicts and Andrej apparently deleted his GitHub account, so I think it can only be closed now. Is anyone interested in resurrecting it?

--

https://issues.dlang.org/show_bug.cgi?id=12558

--- Comment #12 from Andrej Mitrovic <andrej.mitrovich@gmail.com> ---
I'll recreate the pull today or tomorrow.

I'll do the same for the other stale pulls of mine in the coming days.

--

https://issues.dlang.org/show_bug.cgi?id=12558

Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://github.com/D-Progra |https://github.com/D-Progra
                   |mming-Language/dmd/pull/348 |mming-Language/dmd/pull/518
                   |2                           |3

--

https://issues.dlang.org/show_bug.cgi?id=12558

--- Comment #13 from Nick Treleaven <ntrel-pub@mybtinternet.com> ---
(Linked pull 5183 now has conflicts).

I discovered this with dmd 2.071.0:

@safe unittest
{
    try throw new Exception("");
    catch {} // Error: can only catch class objects derived from Exception in
@safe code, not 'object.Throwable'
}

But I think the error should occur in @system code too.

--

https://issues.dlang.org/show_bug.cgi?id=12558

Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrei@erdani.com

--- Comment #14 from Andrej Mitrovic <andrej.mitrovich@gmail.com> ---
CC Andrei for approval, then I'll update the PR.

--

https://issues.dlang.org/show_bug.cgi?id=12558

--- Comment #15 from Andrei Alexandrescu <andrei@erdani.com> ---
Yes, catching Errors should always be explicit.

--

https://issues.dlang.org/show_bug.cgi?id=12558

--- Comment #16 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/9ebcbed84fcc3cb065d506180e3323d976ca266a Fix Issue 12558 - Deprecate implicit catch statements

https://github.com/dlang/dmd/commit/18e6844d41e34cd67df713d31bdf350927e7d5ec Merge pull request #5183 from AndrejMitrovic/fix-12558

Issue 12558 - Deprecate implicit catch statements

--