On 26-09-2012 13:47, monarch_dodra wrote:
> On Tuesday, 25 September 2012 at 22:09:37 UTC, Andrei Alexandrescu wrote:
>> Hello all,
>>
>> [SNIP]
>>
>> We want to move dmd forward faster, and we're encouraging committers
>> to be more aggressive about reviewing and merging patches. Language
>> changes will still have to get through Scylla and Charybdis (that's
>> Walter and yours truly), but bug fixes and other non-controversial
>> work can be safely parallelized.
>>
>> [SNIP]
>>
>> Thanks,
>>
>> Andrei
>>
>> [SNIP]
>
> Any chance we could see some sort of "dedicated hand holders" for the
> newer contributors? That or "semi-trusted" validators: They wouldn't
> have the power to merge themselves, but could still tag pulls as
> "Validated by XXX": Basically, a screening process.

There are several people who go over pull requests and weigh in on them even though they are not committers (me being one). Anyone can feel free to do so. :)

>
> I know that personally, I feel like I can help, but at the same time, I
> know I sometimes try to push some bad code/design. I'm glad there is
> someone that actually takes the time to review my code, but at the same
> time, I don't want to bother the dedicated pullers that already have a
> lot on their plate.

From what I've seen, it's not like your pull requests have been completely unreasonable or annoying to review or anything.

I see it as the responsibility of committers/authors to review pull requests that touch areas they're familiar with, so long as their spare time permits it.

>
> Also (but more related to Phobos), I have myself tried to review others'
> code (when my field of knowledge permits), but it seems like it is not
> something that is done very often.

Yes, we desperately need more people to do reviews.

>
> Overall, I think the most important thing would be promoting cross
> puller reviews. If only just to say "looks good to me!": It can give the
> puller that extra confidence in the pull, without having to delve into it.
>
> I don't mind having to wait 3 weeks for a pull to go through, but it is
> kind of weird when the pull just sits there with no comments *from
> anyone* during those 3 weeks...

It's quite unfortunate that pull request reviews take so long in our community, and it really is something we need to fix. But without people actually willing to do reviews, we're not going to get anywhere.

Perhaps a post in D.announce that encourages peer review would be in order.

-- 
Alex Rønne Petersen
alex@lycus.org
http://lycus.org

On 9/26/12 11:19 AM, Alex Rønne Petersen wrote:
> On 26-09-2012 13:47, monarch_dodra wrote:
>> Any chance we could see some sort of "dedicated hand holders" for the
>> newer contributors? That or "semi-trusted" validators: They wouldn't
>> have the power to merge themselves, but could still tag pulls as
>> "Validated by XXX": Basically, a screening process.
>
> There are several people who go over pull requests and weigh in on them
> even though they are not committers (me being one). Anyone can feel free
> to do so. :)

I should add that I've always found your comments and LGTMs very useful. I meant to write that in reply to one of them, but forgot. Thanks!



Andrei

On Tuesday, 25 September 2012 at 22:09:37 UTC, Andrei Alexandrescu wrote:
> Hello all,
>
>
> There's quite a few changes that we're very excited about, that I'd love to share to the extent possible.
>
> First, we have decided to extend commit rights to Daniel Murphy and Martin Nowak, two heavyweight dmd contributors better known under their noms de plume: yebblies and dawgfoto, respectively. Please join me in congratulating them for this token of appreciation for their talent and hard work.
>

This is great news!

Congratulations Daniel and Martin!

On Tuesday, 25 September 2012 at 22:09:37 UTC, Andrei Alexandrescu wrote:
> Hello all,
>
>
> There's quite a few changes that we're very excited about, that I'd love to share to the extent possible.
>
> First, we have decided to extend commit rights to Daniel Murphy and Martin Nowak, two heavyweight dmd contributors better known under their noms de plume: yebblies and dawgfoto, respectively. Please join me in congratulating them for this token of appreciation for their talent and hard work.

You guys are great! Keep up the good work!

On Thursday, September 27, 2012 00:16:41 Philippe Sigaud wrote:
> On Tuesday, 25 September 2012 at 22:09:37 UTC, Andrei Alexandrescu wrote:
> > Hello all,
> > 
> > 
> > There's quite a few changes that we're very excited about, that I'd love to share to the extent possible.
> > 
> > First, we have decided to extend commit rights to Daniel Murphy and Martin Nowak, two heavyweight dmd contributors better known under their noms de plume: yebblies and dawgfoto, respectively. Please join me in congratulating them for this token of appreciation for their talent and hard work.
>
> You guys are great! Keep up the good work!

Indeed. We're lucky to have them.

- Jonathan M Davis

On 9/26/12 6:16 PM, Philippe Sigaud wrote:
> On Tuesday, 25 September 2012 at 22:09:37 UTC, Andrei Alexandrescu wrote:
>> Hello all,
>>
>>
>> There's quite a few changes that we're very excited about, that I'd love
>> to share to the extent possible.
>>
>> First, we have decided to extend commit rights to Daniel Murphy and Martin
>> Nowak, two heavyweight dmd contributors better known under their noms de
>> plume: yebblies and dawgfoto, respectively. Please join me in congratulating
>> them for this token of appreciation for their talent and hard work.
>
> You guys are great! Keep up the good work!

You are great, too, and would be even greater if you finalized your parser generator and submitted it to Phobos. Most of the questions I get asked at conferences are about your parser and Dmitry's regex.

Andrei

On Thu, Sep 27, 2012 at 1:30 AM, Andrei Alexandrescu <SeeWebsiteForEmail@erdani.org> wrote:

> You are great, too, and would be even greater if you finalized your parser generator and submitted it to Phobos. Most of the questions I get asked at conferences are about your parser and Dmitry's regex.

Thanks. That's why I keep having people forking/starring it on github
:) And that's why I'm working on it regularly: I recently upgraded its
speed by one to two orders of magnitude (almost two in fact) at
compile- and runtime, got it linear by using memoization, added
introspection capabilities and grammar diagnostic. I also corrected
numerous bugs and maybe found a way to deal with left-recursive rules
which the D grammar is so fond of.
I'm now using it to get a pattern-matching engine in D: it's heavily
related to the recent tuple thread, where many people ask for
deconstruction, only I'm doing it for any type and range.

Philippe

On 9/27/12 1:00 AM, Philippe Sigaud wrote:
> On Thu, Sep 27, 2012 at 1:30 AM, Andrei Alexandrescu
> <SeeWebsiteForEmail@erdani.org>  wrote:
>
>> You are great, too, and would be even greater if you finalized your parser
>> generator and submitted it to Phobos. Most of the questions I get asked at
>> conferences are about your parser and Dmitry's regex.
>
> Thanks. That's why I keep having people forking/starring it on github
> :) And that's why I'm working on it regularly: I recently upgraded its
> speed by one to two orders of magnitude (almost two in fact) at
> compile- and runtime, got it linear by using memoization, added
> introspection capabilities and grammar diagnostic. I also corrected
> numerous bugs and maybe found a way to deal with left-recursive rules
> which the D grammar is so fond of.
> I'm now using it to get a pattern-matching engine in D: it's heavily
> related to the recent tuple thread, where many people ask for
> deconstruction, only I'm doing it for any type and range.
>
> Philippe

This is a 50 shades beyond awesome, and has "Phobos submission before the end of 2012 (and the world)" written all over it!

Andrei

Le 26/09/2012 00:10, Andrei Alexandrescu a écrit :
> There's quite a few changes that we're very excited about, that I'd love
> to share to the extent possible.
>
> First, we have decided to extend commit rights to Daniel Murphy and
> Martin Nowak, two heavyweight dmd contributors better known under their
> noms de plume: yebblies and dawgfoto, respectively. Please join me in
> congratulating them for this token of appreciation for their talent and
> hard work.
>

Congratulations ! You deserve it.