Thread overview
[Issue 21555] std.container.array: insertBack is wrong and should be tested for Array!bool
[Issue 21555] insertBack is wrong and should be tested for Array!bool
Jan 18, 2021
Luís Ferreira
Jan 18, 2021
Luís Ferreira
Jan 18, 2021
Luís Ferreira
Jan 18, 2021
Dlang Bot
Jan 19, 2021
Dlang Bot
January 18, 2021
https://issues.dlang.org/show_bug.cgi?id=21555

--- Comment #1 from Luís Ferreira <lsferreira169@gmail.com> ---
I'm already working on a fix.

--
January 18, 2021
https://issues.dlang.org/show_bug.cgi?id=21555

Luís Ferreira <lsferreira169@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|insertBack is wrong and     |std.container.array:
                   |should be tested for        |insertBack is wrong and
                   |Array!bool                  |should be tested for
                   |                            |Array!bool

--
January 18, 2021
https://issues.dlang.org/show_bug.cgi?id=21555

Luís Ferreira <lsferreira169@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21556


Referenced Issues:

https://issues.dlang.org/show_bug.cgi?id=21556
[Issue 21556] std.container.array: insertAfter is wrong and should be tested
--
January 18, 2021
https://issues.dlang.org/show_bug.cgi?id=21555

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #2 from Dlang Bot <dlang-bot@dlang.rocks> ---
@ljmf00 updated dlang/phobos pull request #7750 "Fix issue 21555, 21556 - container: array: insertAfter and insertBack are wrong" fixing this issue:

- Fix issue 21555: std.container.array: insertBack is wrong and should be tested for Array!bool

  insertBack() returns 0 inserted elements everytime due to a preformed
  .popFront() on the range.

  Signed-off-by: Luís Ferreira <contact@lsferreira.net>

- Fix issues 21555, 21556: container: array: add missing tests for Array!T .insertBack and .insertAfter

  Signed-off-by: Luís Ferreira <contact@lsferreira.net>

https://github.com/dlang/phobos/pull/7750

--
January 19, 2021
https://issues.dlang.org/show_bug.cgi?id=21555

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/phobos pull request #7750 "Fix issue 21555, 21556 - container: array: insertAfter and insertBack are wrong" was merged into master:

- 93ebaa729116a813ebb2a8d175abe4400ec00ecf by Luís Ferreira:
  Fix issue 21555: std.container.array: insertBack is wrong and should be
tested for Array!bool

  insertBack() returns 0 inserted elements everytime due to a preformed
  .popFront() on the range.

  Signed-off-by: Luís Ferreira <contact@lsferreira.net>

- 30f71fd5705beaa3dc9c5131b081c60ccaa0974c by Luís Ferreira:
  Fix issues 21555, 21556: container: array: add missing tests for Array!T
.insertBack and .insertAfter

  Signed-off-by: Luís Ferreira <contact@lsferreira.net>

https://github.com/dlang/phobos/pull/7750

--