July 28, 2016 Re: Code coverage in Phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Walter Bright | On Thursday, 28 July 2016 at 23:11:04 UTC, Walter Bright wrote: > On 7/28/2016 1:46 PM, Seb wrote: >> For now you can click on "Last update 6db08d3...bb94012" to see the diff with >> overlayed code coverage. > > I don't see where that link is. Sorry about being so vague. e.g. on this PR (https://github.com/dlang/phobos/pull/4657), there is the following message. The link "Last update" is on the last line. Current coverage is 88.68% (diff: 87.09%) Merging #4655 into master will increase coverage by <.01% @@ master #4655 diff @@ ========================================== Files 121 121 Lines 73827 73849 +22 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 65471 65492 +21 - Misses 8356 8357 +1 Partials 0 0 Powered by Codecov. Last update 6db08d3...2002c65 <-- CLICK HERE |
July 28, 2016 Re: Code coverage in Phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Seb | On 7/28/2016 4:39 PM, Seb wrote:
> e.g. on this PR (https://github.com/dlang/phobos/pull/4657), there is the
> following message. The link "Last update" is on the last line.
Ok, I see it now. Thanks!
|
July 30, 2016 Re: Code coverage in Phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Seb | On Thursday, 28 July 2016 at 20:46:13 UTC, Seb wrote: > On Thursday, 28 July 2016 at 20:30:50 UTC, Walter Bright wrote: >> On 7/28/2016 11:51 AM, Seb wrote: >>> Older PRs don't show a coverage report, because the report needs to be uploaded >>> & they don't have this in their `.travis.yml` yet. However rebasing should fix >>> this. >> >> I rebased https://github.com/dlang/phobos/pull/4657 but it still shows [No coverage] > > ... but it shows that those three lines are never hit ;-) > > As far as I understood [1] the problem is that the CodeCov browser extension has troubles handling merge commits. I will ping you once they resolved the issue and the PR view is working. > > For now you can click on "Last update 6db08d3...bb94012" to see the diff with overlayed code coverage. > > [1] https://github.com/codecov/browser-extension/issues/22 The CodeCov support team is really nice & fast. They found the issue [1] and deployed it today. So the Code coverage browser extension is working for all PRs built on Travis starting from today, e.g. [2] :) [1] https://github.com/codecov/support/issues/263 [2] https://github.com/dlang/phobos/pull/4693/files |
July 30, 2016 Re: Code coverage in Phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Seb | On 7/30/2016 12:05 PM, Seb wrote:
> The CodeCov support team is really nice & fast. They found the issue [1] and
> deployed it today. So the Code coverage browser extension is working for all PRs
> built on Travis starting from today, e.g. [2] :)
>
> [1] https://github.com/codecov/support/issues/263
> [2] https://github.com/dlang/phobos/pull/4693/files
[2] says [No coverage] and clicking on it says "Coverage not found"
:-(
|
July 30, 2016 Re: Code coverage in Phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Walter Bright | On Saturday, 30 July 2016 at 22:35:45 UTC, Walter Bright wrote: > On 7/30/2016 12:05 PM, Seb wrote: >> The CodeCov support team is really nice & fast. They found the issue [1] and >> deployed it today. So the Code coverage browser extension is working for all PRs >> built on Travis starting from today, e.g. [2] :) >> >> [1] https://github.com/codecov/support/issues/263 >> [2] https://github.com/dlang/phobos/pull/4693/files > > [2] says [No coverage] and clicking on it says "Coverage not found" > > :-( You got bad luck, 9il added a commit (so the last commit changed) & the build is currently running and thus "No coverage" is reported. You might try another PR like: https://github.com/dlang/phobos/pull/4647/files |
July 30, 2016 Re: Code coverage in Phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Seb | On 7/30/2016 3:40 PM, Seb wrote:
> You might try another PR like:
>
> https://github.com/dlang/phobos/pull/4647/files
Much better. Thanks!
|
July 30, 2016 Re: Code coverage in Phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Seb | On 7/30/2016 3:40 PM, Seb wrote:
> [...]
Ok, it's time to get this rolling for Druntime, too!
|
July 31, 2016 Re: Code coverage in Phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Walter Bright | On Saturday, 30 July 2016 at 23:50:08 UTC, Walter Bright wrote: > On 7/30/2016 3:40 PM, Seb wrote: >> [...] > > Ok, it's time to get this rolling for Druntime, too! https://github.com/dlang/druntime/pull/1620 ;-) |
July 31, 2016 Re: Code coverage in Phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Seb | On Sunday, 31 July 2016 at 02:08:23 UTC, Seb wrote: > On Saturday, 30 July 2016 at 23:50:08 UTC, Walter Bright wrote: >> On 7/30/2016 3:40 PM, Seb wrote: >>> [...] >> >> Ok, it's time to get this rolling for Druntime, too! > > https://github.com/dlang/druntime/pull/1620 ;-) It turns out it's not that difficult to get it working for DMD, too! :) https://github.com/dlang/dmd/pull/5990 |
Copyright © 1999-2021 by the D Language Foundation