On Monday, 6 October 2014 at 18:15:08 UTC, Sönke Ludwig wrote:
> Am 06.10.2014 13:36, schrieb bioinfornatics:
>> Thanks for your works,
>>
>> One question, what about makefile support ?
>>
>> Regards
>
> It's still in need for a volunteer. The implementation itself should be pretty straightforward (by inheriting from the ProjectGenerator class), but I currently have too much higher priority stuff on my table to get that done (plus generally severely limited time due to an accumulation of work and non-work related things).

I take a look but without a hacker doc that is not easy. So I
have some question ( do nott blame me )

---------------
why class who inherit from ProjectGenerator:
- should to get PackageManager as parameter in ctor (1) while
Project(2) struct has a PackageManager. Project struct is send
too in the ctor.

1)
https://github.com/D-Programming-Language/dub/blob/master/source/dub/generators/build.d#L39
2)
https://github.com/D-Programming-Language/dub/blob/master/source/dub/project.d#L39

---------------
why method:
generateTargets( in GeneratorSettings settings, in
TargetInfo[string] targets)

take an associative array of targets always you use only one
target named m_project.rootPackage.name

---------------
why you assign project (3) this is  not done when super is called
(4)?
3)
https://github.com/D-Programming-Language/dub/blob/master/source/dub/generators/build.d#L42
4)
https://github.com/D-Programming-Language/dub/blob/master/source/dub/generators/generator.d#L48

thanks

Am 07.10.2014 01:35, schrieb bioinfornatics:
> On Monday, 6 October 2014 at 18:15:08 UTC, Sönke Ludwig wrote:
>> Am 06.10.2014 13:36, schrieb bioinfornatics:
>>> Thanks for your works,
>>>
>>> One question, what about makefile support ?
>>>
>>> Regards
>>
>> It's still in need for a volunteer. The implementation itself should
>> be pretty straightforward (by inheriting from the ProjectGenerator
>> class), but I currently have too much higher priority stuff on my
>> table to get that done (plus generally severely limited time due to an
>> accumulation of work and non-work related things).
>
> I take a look but without a hacker doc that is not easy. So I
> have some question ( do nott blame me )

Yeah, sorry about that, the API documentation (and parts of the API itself) definitely need some work. So far the focus has been mostly on getting the functionality done and parts of the code are not ready to be considered clean library code.

>
> ---------------
> why class who inherit from ProjectGenerator:
> - should to get PackageManager as parameter in ctor (1) while
> Project(2) struct has a PackageManager. Project struct is send
> too in the ctor.
>
> 1)
> https://github.com/D-Programming-Language/dub/blob/master/source/dub/generators/build.d#L39
>
> 2)
> https://github.com/D-Programming-Language/dub/blob/master/source/dub/project.d#L39
>

I think this is mostly historically grown and Project could instead have a "packageManager" getter property.

>
> ---------------
> why method:
> generateTargets( in GeneratorSettings settings, in
> TargetInfo[string] targets)
>
> take an associative array of targets always you use only one
> target named m_project.rootPackage.name

The "targets" AA is also used in buildTargetRec(), which in turn goes recursively through the dependency graph and queries all of the targets.

>
> ---------------
> why you assign project (3) this is  not done when super is called
> (4)?
> 3)
> https://github.com/D-Programming-Language/dub/blob/master/source/dub/generators/build.d#L42
>
> 4)
> https://github.com/D-Programming-Language/dub/blob/master/source/dub/generators/generator.d#L48

That's just garbage left over from a refactoring. I'll remove the m_project field in BuildGenerator.

Am 06.10.2014 23:14, schrieb Nick Sabalausky:
> On 10/06/2014 02:15 PM, Sönke Ludwig wrote:
>> Am 06.10.2014 13:36, schrieb bioinfornatics:
>>> Thanks for your works,
>>>
>>> One question, what about makefile support ?
>>>
>>> Regards
>>
>> It's still in need for a volunteer. The implementation itself should be
>> pretty straightforward (by inheriting from the ProjectGenerator class),
>> but I currently have too much higher priority stuff on my table to get
>> that done (plus generally severely limited time due to an accumulation
>> of work and non-work related things).
>
> I don't suppose there's documentation on the ProjectGenerator class? I
> was (briefly) looking into subclassing that for a "compiler cmdline
> args" output that I think would be helpful, but based on a (again,
> rather brief) glance at and its subclasses I had some trouble grokking
> how it worked. I'll have to take a look again though.

That would actually be a nice example generator. I've now added initial documentation to the Generator class.

On Tuesday, 7 October 2014 at 08:36:37 UTC, Sönke Ludwig wrote:
> Am 06.10.2014 23:14, schrieb Nick Sabalausky:
>> On 10/06/2014 02:15 PM, Sönke Ludwig wrote:
>>> Am 06.10.2014 13:36, schrieb bioinfornatics:
>>>> Thanks for your works,
>>>>
>>>> One question, what about makefile support ?
>>>>
>>>> Regards
>>>
>>> It's still in need for a volunteer. The implementation itself should be
>>> pretty straightforward (by inheriting from the ProjectGenerator class),
>>> but I currently have too much higher priority stuff on my table to get
>>> that done (plus generally severely limited time due to an accumulation
>>> of work and non-work related things).
>>
>> I don't suppose there's documentation on the ProjectGenerator class? I
>> was (briefly) looking into subclassing that for a "compiler cmdline
>> args" output that I think would be helpful, but based on a (again,
>> rather brief) glance at and its subclasses I had some trouble grokking
>> how it worked. I'll have to take a look again though.
>
> That would actually be a nice example generator. I've now added initial documentation to the Generator class.


Thanks I will continue to look "how to add makefile supprt?" after my job time.

>>  - Added general support for single-file compilation mode, as well as
>>    separate compile/link mode for GDC.
>>

I do not see any mentions about this key at docs. Can I add it to dub.json?

On Thursday, 13 November 2014 at 11:06:06 UTC, Suliman wrote:
>
>>> - Added general support for single-file compilation mode, as well as
>>>   separate compile/link mode for GDC.
>>>
>
> I do not see any mentions about this key at docs. Can I add it to dub.json?

Nope. It must be specified from the command-line. The relevant option, `build-mode`, is accessible through `dub build --help` (or any of the command that subclass build).

Congrathx!