On Monday, 28 December 2015 at 07:11:00 UTC, Jack Stouffer wrote:
> Voting has ended! Thanks to everyone who voted and reviewed.
>
> The final tally:
>
> Yes: 12
> No: 0

Anything left to review/do on the PR? We're branching for 2.070 soon, would be nice if this can make it, but only if it's really ready.

On Monday, 28 December 2015 at 11:13:57 UTC, Martin Nowak wrote:
> On Monday, 28 December 2015 at 07:11:00 UTC, Jack Stouffer wrote:
>> Voting has ended! Thanks to everyone who voted and reviewed.
>>
>> The final tally:
>>
>> Yes: 12
>> No: 0
>
> Anything left to review/do on the PR?

Very minor DDOC style hack can be fixed. I will fix it during first alpha version. The following console code can not be placed with CCODE macros because looks like `Usage:` word breaks it. So it is D CODE with `default` and `is` keywords highlighted for now.

----
$ median-filter --help
Usage: median-filter [<options...>] [<file_names...>]
options:
     --nr number of rows in window, default value is 3
     --nc number of columns in window default value equals to nr
-h --help This help information.
----

> We're branching for 2.070 soon, would be nice if this can make it, but only if it's really ready.

Whooohooo!

Thanks!

Ilya

On Monday, 28 December 2015 at 11:13:57 UTC, Martin Nowak wrote:
> On Monday, 28 December 2015 at 07:11:00 UTC, Jack Stouffer wrote:
>> Voting has ended! Thanks to everyone who voted and reviewed.
>>
>> The final tally:
>>
>> Yes: 12
>> No: 0
>
> Anything left to review/do on the PR? We're branching for 2.070 soon, would be nice if this can make it, but only if it's really ready.

I believe, with Ilya's recent doc fix, it's ready to go.

On 12/28/2015 09:57 AM, Jack Stouffer wrote:
> On Monday, 28 December 2015 at 11:13:57 UTC, Martin Nowak wrote:
>> On Monday, 28 December 2015 at 07:11:00 UTC, Jack Stouffer wrote:
>>> Voting has ended! Thanks to everyone who voted and reviewed.
>>>
>>> The final tally:
>>>
>>> Yes: 12
>>> No: 0
>>
>> Anything left to review/do on the PR? We're branching for 2.070 soon,
>> would be nice if this can make it, but only if it's really ready.
>
> I believe, with Ilya's recent doc fix, it's ready to go.

Let's do it. Many thanks to Ilya and all reviewers! -- Andrei

On Monday, 28 December 2015 at 07:11:00 UTC, Jack Stouffer wrote:
> The final tally:
>
> Yes: 12
> No: 0

This is not true, my yes was conditional and the documentation is still weak. So it is

Yes: 11
Yes: Conditional
No: 0

Please do not merge this with the current state of documentation.

On Monday, 28 December 2015 at 15:52:09 UTC, Robert burner Schadek wrote:
> Please do not merge this with the current state of documentation.

Could you elaborate what issues you have with the docs? All of the functions have Params and Returns sections and the examples show what each function does.

On Monday, 28 December 2015 at 15:52:09 UTC, Robert burner Schadek wrote:
> On Monday, 28 December 2015 at 07:11:00 UTC, Jack Stouffer wrote:
>> The final tally:
>>
>> Yes: 12
>> No: 0
>
> This is not true, my yes was conditional and the documentation is still weak. So it is
>
> Yes: 11
> Yes: Conditional
> No: 0
>
> Please do not merge this with the current state of documentation.

Have you read the latest changes?
http://forum.dlang.org/post/djgkkrdufycyjhpmafse@forum.dlang.org

I have write documentation as I understand problem. I don't know what would be not weak for you. This module has three levels. User should study them one by one if he is new be (slice, iteration, selection). I am not a book author, I can describe something to my colleagues, but I have not any understanding of what would be _not weak_.

If you _really_ have  read all documentation one by one with attention and you have some question, please write them. Then I can improve documentsion.

Ilya

On Monday, 28 December 2015 at 15:52:09 UTC, Robert burner Schadek wrote:

fix

> Yes: 11
> Yes: Conditional: 1 <<-- fix here
> No: 0

> Please do not merge this with the current state of documentation.

On Monday, 28 December 2015 at 18:39:47 UTC, Ilya Yaroshenko wrote:
> Have you read the latest changes?
> http://forum.dlang.org/post/djgkkrdufycyjhpmafse@forum.dlang.org
>

I have.

The problem with the doc is that is describes what it can be used for, but it does not describe what it is.

It is like saying: "It brings you from point A to point B."
Instead you should say it is a car. And a car is self moving object ....

The first few sentences:
"""
The package is designed for applications such as linear algebra, physics and statistics. It would be well suited to creating machine learning and image processing algorithms, but should also be general enough for use anywhere with homogeneously-typed multidimensional data.
"""
does not say what it is.

Should be something, as far as I understand the package, like:

"""
This package provides a multidimensional array implementation, suited for scientific computing. Additionally, many functions for iteration, accessing and manipulation are given. ....
"""

On 12/28/2015 04:43 PM, Robert burner Schadek wrote:
> On Monday, 28 December 2015 at 18:39:47 UTC, Ilya Yaroshenko wrote:
>> Have you read the latest changes?
>> http://forum.dlang.org/post/djgkkrdufycyjhpmafse@forum.dlang.org
>>
>
> I have.
>
> The problem with the doc is that is describes what it can be used for,
> but it does not describe what it is.
>
> It is like saying: "It brings you from point A to point B."
> Instead you should say it is a car. And a car is self moving object ....
>
> The first few sentences:
> """
> The package is designed for applications such as linear algebra, physics
> and statistics. It would be well suited to creating machine learning and
> image processing algorithms, but should also be general enough for use
> anywhere with homogeneously-typed multidimensional data.
> """
> does not say what it is.
>
> Should be something, as far as I understand the package, like:
>
> """
> This package provides a multidimensional array implementation, suited
> for scientific computing. Additionally, many functions for iteration,
> accessing and manipulation are given. ....
> """

FWIW I noticed that too. It took me a while to figure what the thing really is. -- Andrei