On Wednesday, 20 March 2019 at 22:11:00 UTC, Mike Franklin wrote:
> On Wednesday, 20 March 2019 at 21:58:46 UTC, sighoya wrote:
>
>> How can I help if I'm not the one creating the PR?
>
> It needs someone willing to adopt the PR and work with reviewers to get it across the finish line.  If you've never worked on DMD before, cloning the DMD, druntime, Phobos, etc. and learning how to build the compiler and run the test suite locally is the first step.
>
> Mike

So I can become a reviewer only, but how can I merge additions requested by reviewers, this can only be done by the PR proposer, right?

On Thursday, 21 March 2019 at 07:08:41 UTC, sighoya wrote:

> So I can become a reviewer only, but how can I propose changes to be merged into the PR proposer's branch, do I need to clone his branch and to create a pull request in hope he accept my changes?

Create a new branch, merge the original author's work into your branch, then add your edits, and submit a new PR.  That's what I'd do anyway.

Mike

On Thursday, 21 March 2019 at 11:17:52 UTC, Mike Franklin wrote:
> Create a new branch, merge the original author's work into your branch, then add your edits, and submit a new PR.  That's what I'd do anyway.
>
> Mike

Glad to hear.
But does it make sense when there is already one pull request open: https://github.com/dlang/dmd/pull/8378 ?

On Thursday, 21 March 2019 at 11:29:54 UTC, sighoya wrote:
> On Thursday, 21 March 2019 at 11:17:52 UTC, Mike Franklin wrote:
>> Create a new branch, merge the original author's work into your branch, then add your edits, and submit a new PR.  That's what I'd do anyway.
>>
>> Mike
>
> Glad to hear.
> But does it make sense when there is already one pull request open: https://github.com/dlang/dmd/pull/8378 ?

IMO, yes.

Mike

On Friday, 10 October 2014 at 17:09:08 UTC, IgorStepanov wrote:
> I've created DIP for my pull request.
> DIP: http://wiki.dlang.org/DIP66
> PR: https://github.com/D-Programming-Language/dmd/pull/3998
>
> Please, comment it.

What happened to this dip? Do we have an implementation or not and what is the holdup for this being added to the compiler? It's been over one year.

Multiple alias this would help me a lot and I want (multiple alias) this.

On Sunday, 27 September 2020 at 20:43:29 UTC, IGotD- wrote:
> On Friday, 10 October 2014 at 17:09:08 UTC, IgorStepanov wrote:
>> I've created DIP for my pull request.
>> DIP: http://wiki.dlang.org/DIP66
>> PR: https://github.com/D-Programming-Language/dmd/pull/3998
>>
>> Please, comment it.
>
> What happened to this dip? Do we have an implementation or not and what is the holdup for this being added to the compiler? It's been over one year.
>
> Multiple alias this would help me a lot and I want (multiple alias) this.

It been deprecated as Walter discovered that the current alias this introduce the diamond problem. That and other sorts of bugs that it has.

-Alex

On Sunday, 27 September 2020 at 21:52:15 UTC, 12345swordy wrote:
>
> It been deprecated as Walter discovered that the current alias this introduce the diamond problem. That and other sorts of bugs that it has.
>
> -Alex

It doesn't because it isn't inheritance. What you can end up with is symbol collisions but in that case you can just give an error message.

You can always go to the Rust forum and first try to convince them that Rust has multiple inheritance and then that Rust is evil because it has that. Good luck.

On Sunday, 27 September 2020 at 21:52:15 UTC, 12345swordy wrote:
> It been deprecated as Walter discovered that the current alias this introduce the diamond problem. That and other sorts of bugs that it has.
>
> -Alex

Couldn't this be fixed by not having inheritance of alias this?

On Sunday, 27 September 2020 at 22:23:27 UTC, IGotD- wrote:
> On Sunday, 27 September 2020 at 21:52:15 UTC, 12345swordy wrote:
>>
>> It been deprecated as Walter discovered that the current alias this introduce the diamond problem. That and other sorts of bugs that it has.
>>
>> -Alex
>
> It doesn't because it isn't inheritance.

Walter has comment on this on reddit already. It is not happening. I'm sorry to disappoint you.

What do you need multi alias this for anyway? Composite programming can already do what alias this can do expect implicit conversion.

-Alex

On Sunday, 27 September 2020 at 23:34:31 UTC, 12345swordy wrote:
>
> What do you need multi alias this for anyway? Composite programming can already do what alias this can do expect implicit conversion.
>
> -Alex

Yes, exactly that, creating multiple composites. I know that you can do it with mixin templates but kind of ugly. So if I have an implementation, I need a struct with that implementation in it's pure form and also structs where the implementation is inserted. Now you have a disconnected implementation and then a base struct to begin with. So if you want to reuse your code you basically have to make mixin templates of everything. Was it that solution you were referring to?