On Tue, Aug 16, 2011 at 10:08 AM, David Nadlinger <span dir="ltr">&lt;<a href="mailto:see@klickverbot.at" target="_blank">see@klickverbot.at</a>&gt;</span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">




Seems like the reviews are already coming in steadily, but we still have no review manager – if nobody else steps up until tomorrow, I&#39;d volunteer so we can get the formal review process going.<br><font color="#888888">
<br>
David</font><div><div></div><div><br>
<br>
<br>
On 8/16/11 1:48 PM, Jonas Drewsen wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
This is a review request for the curl wrapper. Please read the &quot;known<br>
issues&quot; in the top of the source file and if possible suggest a solution.<br>
<br>
We also need somebody for running the review process. Anyone?<br>
<br>
Code:<br>
<a href="https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d" target="_blank">https://github.com/jcd/phobos/<u></u>blob/curl-wrapper/etc/curl.d</a><br>
Docs:<br>
<a href="http://freeze.steamwinter.com/D/web/phobos/etc_curl.html" target="_blank">http://freeze.steamwinter.com/<u></u>D/web/phobos/etc_curl.html</a><br>
<br>
Demolish!<br>
<br>
/Jonas<br>
</blockquote>
<br>
</div></div></blockquote></div><br><div><br></div><div>On line 80, I made a typo when writing the documentation:</div><div><br></div><div><a href="https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d#L80" target="_blank">https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d#L80</a></div>




<div><br></div><div>It should be:</div>&lt;<a href="mailto:to.addr@gmail.com" target="_blank">to.addr@gmail.com</a>&gt;<div><br></div><div>After reading the libcurl documentation, I realize that the automatic angle bracket attaching at lines 2932 and 2943 are not needed (libcurl seems to do it for you after version 7.21.4).</div>



<div><br></div>