View mode: basic / threaded / horizontal-split · Log in · Help
February 02, 2012
std.uuid is ready for review
Hi,

std.uuid is ready to be reviewed. As far as I know there's nothing
being reviewed right now, so we could start the review as soon as 
a review manager has been found.

About std.uuid (copied from the module documentation):
---------------------
This is a port of boost.uuid from the boost project with some minor
additions and API changes for a more D-like API. A UUID, or Universally
unique identifier, is intended to uniquely identify information in a
distributed environment without significant central coordination. It
can be used to tag objects with very short lifetimes, or to reliably
identify very persistent objects across a network. UUIDs have many
applications. [...]
---------------------

Code: https://github.com/jpf91/phobos/blob/std.uuid/std/uuid.d
API-Docs: http://dl.dropbox.com/u/24218791/d/src/uuid.html

Note: The code and documentation for shaUUID has already been written,
but until phobos has support for SHA1, that can't be included. The code
is currently commented out in the source file (it's well tested
with some 3rd party SHA1 code), but the documentation for those
functions is included in the API-docs. I think those functions should
be reviewed as well, so that it's possible to add them to phobos with a
simple pull request at a later date.

Note2: std.uuid also need this pull request:
https://github.com/D-Programming-Language/phobos/pull/398
It adds a isRandomNumberGenerator template to detect if a template
parameter is a random-number generator type.
February 03, 2012
Re: std.uuid is ready for review
On 2012-02-02 22:26, Johannes Pfau wrote:
> Hi,
>
> std.uuid is ready to be reviewed. As far as I know there's nothing
> being reviewed right now, so we could start the review as soon as
> a review manager has been found.
>
> About std.uuid (copied from the module documentation):
> ---------------------
> This is a port of boost.uuid from the boost project with some minor
> additions and API changes for a more D-like API. A UUID, or Universally
> unique identifier, is intended to uniquely identify information in a
> distributed environment without significant central coordination. It
> can be used to tag objects with very short lifetimes, or to reliably
> identify very persistent objects across a network. UUIDs have many
> applications. [...]
> ---------------------
>
> Code: https://github.com/jpf91/phobos/blob/std.uuid/std/uuid.d
> API-Docs: http://dl.dropbox.com/u/24218791/d/src/uuid.html
>
> Note: The code and documentation for shaUUID has already been written,
> but until phobos has support for SHA1, that can't be included. The code
> is currently commented out in the source file (it's well tested
> with some 3rd party SHA1 code), but the documentation for those
> functions is included in the API-docs. I think those functions should
> be reviewed as well, so that it's possible to add them to phobos with a
> simple pull request at a later date.
>
> Note2: std.uuid also need this pull request:
> https://github.com/D-Programming-Language/phobos/pull/398
> It adds a isRandomNumberGenerator template to detect if a template
> parameter is a random-number generator type.

My serialization library Orange was in the review queue before, for a 
pre-review, but nothing happened with that. I you want to review 
std.uuid before I have no problem with that.

-- 
/Jacob Carlborg
February 03, 2012
Re: std.uuid is ready for review
Am Fri, 03 Feb 2012 09:54:32 +0100
schrieb Jacob Carlborg <doob@me.com>:

> On 2012-02-02 22:26, Johannes Pfau wrote:
> > Hi,
> >
> > std.uuid is ready to be reviewed. As far as I know there's nothing
> > being reviewed right now, so we could start the review as soon as
> > a review manager has been found.
> >
> > About std.uuid (copied from the module documentation):
> > ---------------------
> > This is a port of boost.uuid from the boost project with some minor
> > additions and API changes for a more D-like API. A UUID, or
> > Universally unique identifier, is intended to uniquely identify
> > information in a distributed environment without significant
> > central coordination. It can be used to tag objects with very short
> > lifetimes, or to reliably identify very persistent objects across a
> > network. UUIDs have many applications. [...]
> > ---------------------
> >
> > Code: https://github.com/jpf91/phobos/blob/std.uuid/std/uuid.d
> > API-Docs: http://dl.dropbox.com/u/24218791/d/src/uuid.html
> >
> > Note: The code and documentation for shaUUID has already been
> > written, but until phobos has support for SHA1, that can't be
> > included. The code is currently commented out in the source file
> > (it's well tested with some 3rd party SHA1 code), but the
> > documentation for those functions is included in the API-docs. I
> > think those functions should be reviewed as well, so that it's
> > possible to add them to phobos with a simple pull request at a
> > later date.
> >
> > Note2: std.uuid also need this pull request:
> > https://github.com/D-Programming-Language/phobos/pull/398
> > It adds a isRandomNumberGenerator template to detect if a template
> > parameter is a random-number generator type.
> 
> My serialization library Orange was in the review queue before, for a 
> pre-review, but nothing happened with that. I you want to review 
> std.uuid before I have no problem with that.
> 

I thought orange wasn't 100% ready for review yet, but if it is I don't
mind if it's reviewed first. std.uuid has the benefit that it's small,
simple and ported from boost, so it's kinda 'well-tested' and the
review hopefully won't be very controversial.
February 04, 2012
Re: std.uuid is ready for review
On 2012-02-03 23:18, Johannes Pfau wrote:
> Am Fri, 03 Feb 2012 09:54:32 +0100
> schrieb Jacob Carlborg<doob@me.com>:
>> My serialization library Orange was in the review queue before, for a
>> pre-review, but nothing happened with that. I you want to review
>> std.uuid before I have no problem with that.
>>
>
> I thought orange wasn't 100% ready for review yet, but if it is I don't
> mind if it's reviewed first. std.uuid has the benefit that it's small,
> simple and ported from boost, so it's kinda 'well-tested' and the
> review hopefully won't be very controversial.

It depends on how you see it. I've requested, what I would like to call 
a pre-review. I want to have a regular review on what I have, but with 
the assumption that if it gets approved I will remove all Tango support. 
I don't want to waste time on removing the Tango support if I don't know 
for sure it will be included in Phobos.

-- 
/Jacob Carlborg
February 04, 2012
Re: std.uuid is ready for review
On 2012-02-03 23:18, Johannes Pfau wrote:
>
> I thought orange wasn't 100% ready for review yet, but if it is I don't
> mind if it's reviewed first. std.uuid has the benefit that it's small,
> simple and ported from boost, so it's kinda 'well-tested' and the
> review hopefully won't be very controversial.

Actually I don't care in what order the modules are reviewed.

-- 
/Jacob Carlborg
February 06, 2012
Re: std.uuid is ready for review
Johannes Pfau wrote:
> Hi,

Hi,

SHA1 and MD5 should work in CTFE now.
February 06, 2012
Re: std.uuid is ready for review
Am 06.02.2012, 03:44 Uhr, schrieb Piotr Szturmaj <bncrbme@jadamspam.pl>:

> Johannes Pfau wrote:
>> Hi,
>
> Hi,
>
> SHA1 and MD5 should work in CTFE now.

So I could in theory do import("important.binary") and calculate and store  
it's checksums in the executable. You never know when you need this  
feature!
February 06, 2012
Re: std.uuid is ready for review
On 2/2/2012 1:26 PM, Johannes Pfau wrote:
> std.uuid is ready to be reviewed. As far as I know there's nothing
> being reviewed right now, so we could start the review as soon as
> a review manager has been found.

I'd like to see a string constant that is a regex for a UUID in its canonical 
form. The user could then simply pass that string to std.regex and pick UUIDs 
out of text.
February 06, 2012
Re: std.uuid is ready for review
Johannes Pfau wrote:
> Code: https://github.com/jpf91/phobos/blob/std.uuid/std/uuid.d
> API-Docs: http://dl.dropbox.com/u/24218791/d/src/uuid.html

<snip>
@trusted UUID shaUUID(const(char[]) name, UUID namespace = nilUUID);
@trusted UUID shaUUID(const(ubyte[]) data, UUID namespace = nilUUID);
</snip>

When casting from void[] to ubyte[] will be working in CTFE (if ever), 
you might use just one function taking const(void[]) and cast it to 
ubyte[] internally.

About name, I think it should be sha1UUID.
February 06, 2012
Re: std.uuid is ready for review
On Monday, 6 February 2012 at 04:46:16 UTC, Marco Leise wrote:
> So I could in theory do import("important.binary") and 
> calculate and store it's checksums in the executable. You never 
> know when you need this feature!

Hmm, wouldn't doing that also mean that important.binary is also 
included as part of the executable, even though you just want the 
checksum?
« First   ‹ Prev
1 2 3
Top | Discussion index | About this forum | D home