October 31, 2015 [D-runtime] [D-Programming-Language/druntime] 828700: remove incorrect comment | ||||
---|---|---|---|---|
| ||||
Attachments:
| Branch: refs/heads/master Home: https://github.com/D-Programming-Language/druntime Commit: 828700134cd8dca4ab0324eb2f320277cc398c97 https://github.com/D-Programming-Language/druntime/commit/828700134cd8dca4ab0324eb2f320277cc398c97 Author: Martin Nowak <code@dawg.eu> Date: 2015-10-31 (Sat, 31 Oct 2015) Changed paths: M src/core/thread.d Log Message: ----------- remove incorrect comment - both Thread.remove and thread_suspendAll synchronize on slock so a double removal isn't possible - we still set isRunning to false b/c some functions must not be called on a stopped thread, e.g. setPriority Commit: be0c48ec135e9263871cc549d690ef6fac4d1965 https://github.com/D-Programming-Language/druntime/commit/be0c48ec135e9263871cc549d690ef6fac4d1965 Author: Martin Nowak <code@dawg.eu> Date: 2015-10-31 (Sat, 31 Oct 2015) Changed paths: M src/core/thread.d Log Message: ----------- fix double removal of thread - happens when removing a running thread (thread_detachInstance) that gets removed again at the end of thread_entryPoint - fixed by setting .prev/.next to null on removal and checking for that - requires the obvious care when removing threads while looping over the list - also helps the GC a bit to collect dead Thread objects Commit: d56a25997c069d6f5e657288f5d2d857dbd1a4fc https://github.com/D-Programming-Language/druntime/commit/d56a25997c069d6f5e657288f5d2d857dbd1a4fc Author: Martin Nowak <code@dawg.eu> Date: 2015-10-31 (Sat, 31 Oct 2015) Changed paths: M src/core/exception.d M src/core/thread.d Log Message: ----------- fix Issue 15268 - deadlock for Thread.getAll/Thread.opApply - fix a deadlock caused by lock order inversion - must not use the GC while holding slock Commit: 713aa0568a0ba7d775e97c59a7590048c5e6d762 https://github.com/D-Programming-Language/druntime/commit/713aa0568a0ba7d775e97c59a7590048c5e6d762 Author: David Nadlinger <code@klickverbot.at> Date: 2015-10-31 (Sat, 31 Oct 2015) Changed paths: M src/core/exception.d M src/core/thread.d Log Message: ----------- Merge pull request #1421 from MartinNowak/fix15268 fix Issue 15268 - deadlock for Thread.getAll/Thread.opApply Compare: https://github.com/D-Programming-Language/druntime/compare/1c95b5827012...713aa0568a0b |
Copyright © 1999-2021 by the D Language Foundation