Thread overview
[dmd-internals] pull queue management
Jul 01, 2017
Brad Roberts
Jul 02, 2017
Sebastian Wilzbach
Jul 04, 2017
Iain Buclaw
July 01, 2017
Ok, everyone knows the pull queues are huge and that a goal of clearing them is long term at best.  I have a much more targeted suggested goal:  Keep the stable pull queue empty.  There's currently 11 pull requests.  There's really no reason for this subset to linger.  Either they're good and low risk fixes for issues or they should be done on master.

    https://auto-tester.puremagic.com/pulls.ghtml?projectid=14
    Or a github search with the filter: base:stable
https://github.com/dlang/dmd/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20base%3Astable

A quick bit of focused effort to handle the existing queue then a daily job to send an email about the existence of anything older than a day?  Or maybe anything at all.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals
July 02, 2017
Brad, I think this is a great idea!

I have already opened an issue at the Dlang-Bot [1] (the bot already crawls the PRs daily and tags them e.g. "stalled", "needs rebase", "needs work" etc.)
So configuring the bot to send a daily reminder to this mailing list about stable PRs shouldn't be difficult.
Maybe we should start to send reminders as soon as the bot has this feature?

I will be busy for a few days, but afterwards I can have a look into [1].
However, if anyone else wants to hack with the bot [2] is a good starting point (accessible with --cron-daily).

[1] https://github.com/dlang-bots/dlang-bot/issues/119
[2] https://github.com/dlang-bots/dlang-bot/blob/master/source/dlangbot/github.d#L325

On 2017-07-01 20:25, Brad Roberts via dmd-internals wrote:
> Ok, everyone knows the pull queues are huge and that a goal of
> clearing them is long term at best.  I have a much more targeted
> suggested goal:  Keep the stable pull queue empty.  There's currently
> 11 pull requests.  There's really no reason for this subset to linger.
>  Either they're good and low risk fixes for issues or they should be
> done on master.
> 
>     https://auto-tester.puremagic.com/pulls.ghtml?projectid=14
>     Or a github search with the filter: base:stable
> https://github.com/dlang/dmd/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20base%3Astable
> 
> A quick bit of focused effort to handle the existing queue then a
> daily job to send an email about the existence of anything older than
> a day?  Or maybe anything at all.
> _______________________________________________
> dmd-internals mailing list
> dmd-internals@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals
July 04, 2017
On 1 July 2017 at 20:25, Brad Roberts via dmd-internals <dmd-internals@puremagic.com> wrote:
> Ok, everyone knows the pull queues are huge and that a goal of clearing them is long term at best.  I have a much more targeted suggested goal:  Keep the stable pull queue empty.  There's currently 11 pull requests.  There's really no reason for this subset to linger.  Either they're good and low risk fixes for issues or they should be done on master.
>
>     https://auto-tester.puremagic.com/pulls.ghtml?projectid=14
>     Or a github search with the filter: base:stable
> https://github.com/dlang/dmd/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20base%3Astable
>
> A quick bit of focused effort to handle the existing queue then a daily job to send an email about the existence of anything older than a day?  Or maybe anything at all.

I'll clear out all of mine later.  That dmd differences PR should be rebased against a C++ branch.

Iain.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals