Thread overview
[Bug 134] gcc/d/dfrontend/outbuffer.c needs alloca.h on Solarish systems
Jun 14, 2014
Iain Buclaw
Jun 14, 2014
Jason King
Jun 14, 2014
Iain Buclaw
Aug 19, 2015
Iain Buclaw
June 14, 2014
http://bugzilla.gdcproject.org/show_bug.cgi?id=134

--- Comment #1 from Iain Buclaw <ibuclaw@gdcproject.org> ---
Thanks!

Having a look upstream, the include is here: https://github.com/D-Programming-Language/dmd/blob/master/src/root/outbuffer.c

Can you raise a PR for this? https://github.com/D-Programming-GDC/GDC/pulls

-- 
You are receiving this mail because:
You are watching all bug changes.


June 14, 2014
http://bugzilla.gdcproject.org/show_bug.cgi?id=134

--- Comment #2 from Jason King <jason.brian.king@gmail.com> ---
Done -- note the fix corresponds to patching gcc/d/dfrontend/port.h

Looking at gcc/d/dfrontend/port.h, it explicitly includes stdlib.h to get alloca(), so it seems like the check and include should be there.

-- 
You are receiving this mail because:
You are watching all bug changes.


June 14, 2014
http://bugzilla.gdcproject.org/show_bug.cgi?id=134

--- Comment #3 from Iain Buclaw <ibuclaw@gdcproject.org> ---
(In reply to Jason King from comment #2)
> Done -- note the fix corresponds to patching gcc/d/dfrontend/port.h
> 
> Looking at gcc/d/dfrontend/port.h, it explicitly includes stdlib.h to get alloca(), so it seems like the check and include should be there.

My concern is that because upstream differs, this will be overwritten in a month, and having it in the header may mask any other places where it is needed.

-- 
You are receiving this mail because:
You are watching all bug changes.


August 19, 2015
http://bugzilla.gdcproject.org/show_bug.cgi?id=134

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |UPSTREAM

--- Comment #4 from Iain Buclaw <ibuclaw@gdcproject.org> ---
Closing as I believe this has been sorted out in 2.066 merge.

Going to give it a go on a port box though...

-- 
You are receiving this mail because:
You are watching all bug changes.