Thread overview
[Issue 13429] icmp (and friends) should be @nogc
Sep 11, 2014
Robert Schadek
Dec 03, 2015
Infiltrator
Dec 03, 2015
ag0aep6g@gmail.com
Dec 06, 2015
Infiltrator
Mar 23, 2018
Manu
Jun 10, 2019
Nicholas Wilson
September 11, 2014
https://issues.dlang.org/show_bug.cgi?id=13429

Robert Schadek <rburners@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rburners@gmail.com

--
December 03, 2015
https://issues.dlang.org/show_bug.cgi?id=13429

Infiltrator <lt.infiltrator@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |lt.infiltrator@gmail.com
         Resolution|---                         |INVALID

--- Comment #1 from Infiltrator <lt.infiltrator@gmail.com> ---
I think that it does for unicode.

I'm going to close off as INVALID because icmp need unicode.

--
December 03, 2015
https://issues.dlang.org/show_bug.cgi?id=13429

ag0aep6g@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |ag0aep6g@gmail.com
         Resolution|INVALID                     |---

--- Comment #2 from ag0aep6g@gmail.com ---
Reopening.

std.uni.icmp is only not @nogc, because it may throw a GC allocated Exception. Exceptions that don't rely on the GC are being worked towards (e.g. by making them reference counted), in particular to enable more of Phobos to be @nogc.

--
December 06, 2015
https://issues.dlang.org/show_bug.cgi?id=13429

--- Comment #3 from Infiltrator <lt.infiltrator@gmail.com> ---
I was wrong in closing this as INVALID; or at all.  I don't even know what I was thinking.  Sorry for the noise.

--
December 08, 2016
https://issues.dlang.org/show_bug.cgi?id=13429

--- Comment #4 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/40787cee7f3ab4a3c747d47124e614d7b30cbbf1 Issue 13429: make sicmp and icmp @nogc nothrow

https://github.com/dlang/phobos/commit/5c770fba084a5e7addfaf65ab6deb36584ee2fd7 Merge pull request #4933 from sprinkle131313/master

Issue 13429: make sicmp and icmp @nogc nothrow.

--
January 07, 2017
https://issues.dlang.org/show_bug.cgi?id=13429

--- Comment #5 from github-bugzilla@puremagic.com ---
Commits pushed to stable at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/40787cee7f3ab4a3c747d47124e614d7b30cbbf1 Issue 13429: make sicmp and icmp @nogc nothrow

https://github.com/dlang/phobos/commit/5c770fba084a5e7addfaf65ab6deb36584ee2fd7 Merge pull request #4933 from sprinkle131313/master

--
January 16, 2017
https://issues.dlang.org/show_bug.cgi?id=13429

--- Comment #6 from github-bugzilla@puremagic.com ---
Commits pushed to newCTFE at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/40787cee7f3ab4a3c747d47124e614d7b30cbbf1 Issue 13429: make sicmp and icmp @nogc nothrow

https://github.com/dlang/phobos/commit/5c770fba084a5e7addfaf65ab6deb36584ee2fd7 Merge pull request #4933 from sprinkle131313/master

--
March 23, 2018
https://issues.dlang.org/show_bug.cgi?id=13429

Manu <turkeyman@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |industry

--
June 10, 2019
https://issues.dlang.org/show_bug.cgi?id=13429

Nicholas Wilson <iamthewilsonator@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
                 CC|                            |iamthewilsonator@hotmail.co
                   |                            |m
         Resolution|---                         |FIXED

--- Comment #7 from Nicholas Wilson <iamthewilsonator@hotmail.com> ---
This got fixed in https://github.com/dlang/phobos/pull/4933

--