Jump to page: 1 2
Thread overview
[Issue 14564] [REG2.067] dmd -property -unittest combination causes compiler error
[Issue 14564] dmd -property -unittest combination causes compiler error
May 10, 2015
Lucas Burson
May 10, 2015
Lucas Burson
May 10, 2015
ag0aep6g@gmail.com
May 10, 2015
Martin Krejcirik
May 13, 2015
Vladimir Panteleev
May 14, 2015
Vladimir Panteleev
Jun 01, 2015
Kenji Hara
Jun 28, 2015
Jonathan M Davis
Jul 11, 2015
Walter Bright
Jul 21, 2015
Walter Bright
Jul 22, 2015
Jonathan M Davis
Jul 30, 2015
ag0aep6g@gmail.com
Aug 05, 2015
ag0aep6g@gmail.com
Aug 10, 2015
ag0aep6g@gmail.com
May 10, 2015
https://issues.dlang.org/show_bug.cgi?id=14564

--- Comment #1 from Lucas Burson <ljdelight@gmail.com> ---
I forgot to note that the arg combination compiles using the previous version of dmd v2.066.1, and failure in v2.067.1.

--
May 10, 2015
https://issues.dlang.org/show_bug.cgi?id=14564

Lucas Burson <ljdelight@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|x86_64                      |All

--
May 10, 2015
https://issues.dlang.org/show_bug.cgi?id=14564

ag0aep6g@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ag0aep6g@gmail.com
           Severity|normal                      |regression

--- Comment #2 from ag0aep6g@gmail.com ---
(In reply to Lucas Burson from comment #1)
> I forgot to note that the arg combination compiles using the previous version of dmd v2.066.1, and failure in v2.067.1.

Making this a regression.

--
May 10, 2015
https://issues.dlang.org/show_bug.cgi?id=14564

Martin Krejcirik <mk@krej.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|dmd -property -unittest     |[REG2.067] dmd -property
                   |combination causes compiler |-unittest combination
                   |error                       |causes compiler error

--
May 13, 2015
https://issues.dlang.org/show_bug.cgi?id=14564

Vladimir Panteleev <thecybershadow@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thecybershadow@gmail.com

--- Comment #3 from Vladimir Panteleev <thecybershadow@gmail.com> ---
-property is going away, but let's see what the maintainers say.

Introduced in https://github.com/D-Programming-Language/phobos/pull/2723

--
May 14, 2015
https://issues.dlang.org/show_bug.cgi?id=14564

Илья Ярошенко <ilyayaroshenko@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ilyayaroshenko@gmail.com

--- Comment #4 from Илья Ярошенко <ilyayaroshenko@gmail.com> ---
(In reply to Vladimir Panteleev from comment #3)
> -property is going away, but let's see what the maintainers say.
> 
> Introduced in https://github.com/D-Programming-Language/phobos/pull/2723

Also introduced in std.uni (c.isWhite):

@trusted int comparePropertyName(Char1, Char2)(const(Char1)[] a, const(Char2)[]
b)
{
    import std.ascii : toLower;
    import std.algorithm : cmp, map, filter;
    static bool pred(dchar c) {return !c.isWhite && c != '-' && c != '_';}
    return cmp(
        a.map!toLower.filter!pred,
        b.map!toLower.filter!pred);
}

--
May 14, 2015
https://issues.dlang.org/show_bug.cgi?id=14564

--- Comment #5 from Vladimir Panteleev <thecybershadow@gmail.com> ---
(In reply to Илья Ярошенко from comment #4)
> Also introduced in

Please file that as a separate bug.

--
May 14, 2015
https://issues.dlang.org/show_bug.cgi?id=14564

--- Comment #6 from Илья Ярошенко <ilyayaroshenko@gmail.com> ---
I think it is the same bug because the error log by Lucas is about std.uni. If it would be decided that property syntax in Phobos should be fixed I'll fix both bugs.

--
June 01, 2015
https://issues.dlang.org/show_bug.cgi?id=14564

Kenji Hara <k.hara.pg@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|DMD                         |Phobos

--
June 28, 2015
https://issues.dlang.org/show_bug.cgi?id=14564

Jonathan M Davis <issues.dlang@jmdavisProg.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |issues.dlang@jmdavisProg.co
                   |                            |m

--- Comment #7 from Jonathan M Davis <issues.dlang@jmdavisProg.com> ---
We should just change it so that -property does nothing (except maybe print that it's a defunct flag) so that no one's build process gets broken by its removal and so that we no longer have to care about it working.

We _were_ building Phobos with it to ensure that we weren't breaking anyone's code by writing code in templated functions which didn't work with -property, but clearly, we're not doing that anymore.

I think that we either need to be building with -property to ensure that we're not breaking folks code (and thus need to fix this regression), or we need to fix it so that -property does nothing so that there are no compilation errors related to -property.

--
« First   ‹ Prev
1 2