Jump to page: 1 2
Thread overview
[Issue 14750] druntime/test/coverage was added to druntime, but not to the MANIFEST - zip file broken again
Jun 30, 2015
Walter Bright
Jun 30, 2015
Walter Bright
Jul 01, 2015
Martin Nowak
Jul 06, 2015
Walter Bright
Jul 07, 2015
Martin Nowak
Jul 10, 2015
Walter Bright
Jul 10, 2015
Walter Bright
Jul 11, 2015
Jonathan M Davis
Jul 11, 2015
Walter Bright
June 30, 2015
https://issues.dlang.org/show_bug.cgi?id=14750

--- Comment #1 from Walter Bright <bugzilla@digitalmars.com> ---
In fact, it seems none of the files in the test directory are in the manifest.

--
June 30, 2015
https://issues.dlang.org/show_bug.cgi?id=14750

--- Comment #3 from Walter Bright <bugzilla@digitalmars.com> ---
(In reply to Martin Nowak from comment #2)
> (In reply to Walter Bright from comment #0)
> > When adding files to druntime, PLEASE add them to the manifest.
> 
> Please stop recommending repeated manual actions as solutions, they don't work.

I'm fine if someone posts a method of doing this automatically. In the absence of such, it needs to be done manually. Otherwise, things break, as they did for me. There's no point in having a MANIFEST file if it is allowed to get out of sync with the files.


> Why should we distribute the additional tests?

Because running 'make -f posix.mak clean' fails without them. That's how I discovered the problem.

--
July 01, 2015
https://issues.dlang.org/show_bug.cgi?id=14750

--- Comment #4 from Martin Nowak <code@dawg.eu> ---
(In reply to Walter Bright from comment #3)
> I'm fine if someone posts a method of doing this automatically. In the absence of such, it needs to be done manually. Otherwise, things break, as they did for me.

We don't use the MANIFEST file to generate the source trees for the releases
and all the last releases already contain the test folder.
So what exactly was your problem?

--
July 06, 2015
https://issues.dlang.org/show_bug.cgi?id=14750

--- Comment #5 from Walter Bright <bugzilla@digitalmars.com> ---
(In reply to Martin Nowak from comment #4)
> (In reply to Walter Bright from comment #3)
> > I'm fine if someone posts a method of doing this automatically. In the absence of such, it needs to be done manually. Otherwise, things break, as they did for me.
> 
> We don't use the MANIFEST file to generate the source trees for the releases
> and all the last releases already contain the test folder.
> So what exactly was your problem?

--------------------------
make -f win32.mak zip

... copy druntime.zip file to new system ...

unzip druntime.zip
make -fposix.mak MODEL=32 clean
make -C test/init_fini clean
rm -rf obj
make -C test/exceptions clean
rm -rf obj
make[1]: *** No rule to make target `test/coverage/.clean', needed by `clean'.
Stop
make: *** [clean] Error 2
---------------------------

It fails because the files necessary are not there. What's the point of having a MANIFEST if it is only a subset of the manifest?

--
July 07, 2015
https://issues.dlang.org/show_bug.cgi?id=14750

--- Comment #6 from Martin Nowak <code@dawg.eu> ---
(In reply to Walter Bright from comment #5)
> It fails because the files necessary are not there. What's the point of having a MANIFEST if it is only a subset of the manifest?

Exactly, let's delete MANIFEST. The question is why you need it or the zip
rule.
We could replace the rule with
    git archive --format=zip HEAD > druntime.zip
or
    zip druntime.zip $(git ls-files)
depending on whether or not modified working dir files should end up in the
zip.

--
July 10, 2015
https://issues.dlang.org/show_bug.cgi?id=14750

--- Comment #7 from Walter Bright <bugzilla@digitalmars.com> ---
True, you can do that (thanks for the tip!) but the zip file is for use on systems that don't have git.

--
July 10, 2015
https://issues.dlang.org/show_bug.cgi?id=14750

--- Comment #8 from Walter Bright <bugzilla@digitalmars.com> ---
https://github.com/D-Programming-Language/druntime/pull/1323

--
July 11, 2015
https://issues.dlang.org/show_bug.cgi?id=14750

Jonathan M Davis <issues.dlang@jmdavisProg.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |issues.dlang@jmdavisProg.co
                   |                            |m

--- Comment #9 from Jonathan M Davis <issues.dlang@jmdavisProg.com> ---
(In reply to Walter Bright from comment #7)
> True, you can do that (thanks for the tip!) but the zip file is for use on systems that don't have git.

But does it need to be generated on any systems without git? I would have thought that it would be fine for the target for the zip file to only work on systems with git installed, because the primary purpose of the zip file is to create it for distributing a release, and the releases are being done by developers who need git to work on the main D repos in the first place.

--
July 11, 2015
https://issues.dlang.org/show_bug.cgi?id=14750

--- Comment #10 from Walter Bright <bugzilla@digitalmars.com> ---
(In reply to Jonathan M Davis from comment #9)
> But does it need to be generated on any systems without git?

Yes. I do it all the time. That's how I find out when it breaks.

--
July 12, 2015
https://issues.dlang.org/show_bug.cgi?id=14750

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--
« First   ‹ Prev
1 2