Jump to page: 1 2
Thread overview
[Issue 14838] [REG 2.066] Wrong attribute inference for auto-generated class destructor with static array of non-POD type
Jul 28, 2015
ag0aep6g@gmail.com
Jul 29, 2015
Martin Nowak
Jul 29, 2015
Martin Nowak
Jul 29, 2015
Martin Nowak
Jul 29, 2015
Martin Nowak
Jul 29, 2015
Martin Nowak
Jul 29, 2015
Kenji Hara
Aug 04, 2015
Kenji Hara
July 28, 2015
https://issues.dlang.org/show_bug.cgi?id=14838

ag0aep6g@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rejects-valid
                 CC|                            |ag0aep6g@gmail.com
            Summary|Wrong attribute inference   |[REG 2.066] Wrong attribute
                   |for auto-generated class    |inference for
                   |destructor with static      |auto-generated class
                   |array of non-POD type       |destructor with static
                   |                            |array of non-POD type
           Severity|normal                      |regression

--- Comment #1 from ag0aep6g@gmail.com ---
This is a regression in 2.066.

Digger says it's been introduced by https://github.com/D-Programming-Language/dmd/pull/3301

--
July 29, 2015
https://issues.dlang.org/show_bug.cgi?id=14838

--- Comment #2 from Martin Nowak <code@dawg.eu> ---
*** Issue 14839 has been marked as a duplicate of this issue. ***

--
July 29, 2015
https://issues.dlang.org/show_bug.cgi?id=14838

Martin Nowak <code@dawg.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |code@dawg.eu
           Assignee|nobody@puremagic.com        |code@dawg.eu

--
July 29, 2015
https://issues.dlang.org/show_bug.cgi?id=14838

--- Comment #3 from Martin Nowak <code@dawg.eu> ---
The problem is the TypeInfo.destroy call in buildDtor [¹]. We need to replace it with an attribute correct replacement.

[¹]: https://github.com/D-Programming-Language/dmd/blob/3b82f08badcafc7cf373be2182f4b3f5eb5db3b9/src/clone.c#L931

--
July 29, 2015
https://issues.dlang.org/show_bug.cgi?id=14838

--- Comment #4 from Martin Nowak <code@dawg.eu> ---
The bug also exists for struct dtors.

struct Array(T) { ~this() {} }
struct Test { Array!int[1] array; }

--
July 29, 2015
https://issues.dlang.org/show_bug.cgi?id=14838

--- Comment #5 from Martin Nowak <code@dawg.eu> ---
And struct postblits.

struct Array(T) { this(this) @safe {} }
struct Test { Array!int[1] array; }
----
bug2.d(2): Error: safe function 'bug2.Test.__fieldPostblit' cannot call system function 'object.TypeInfo_StaticArray.postblit'
----

--
July 29, 2015
https://issues.dlang.org/show_bug.cgi?id=14838

Kenji Hara <k.hara.pg@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #6 from Kenji Hara <k.hara.pg@gmail.com> ---
(In reply to Martin Nowak from comment #3)
> The problem is the TypeInfo.destroy call in buildDtor [¹]. We need to replace it with an attribute correct replacement.
> 
> [¹]:
> https://github.com/D-Programming-Language/dmd/blob/
> 3b82f08badcafc7cf373be2182f4b3f5eb5db3b9/src/clone.c#L931

Yes. I had missed that in the PR 3301.

https://github.com/D-Programming-Language/dmd/pull/4845

--
July 30, 2015
https://issues.dlang.org/show_bug.cgi?id=14838

--- Comment #7 from github-bugzilla@puremagic.com ---
Commits pushed to stable at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/d167403e777bcf91c50a7fd8eedf5100ac1ab50d
fix Issue 14838 - Wrong attribute inference for auto-generated class destructor
with static array of non-POD type

https://github.com/D-Programming-Language/dmd/commit/7e531002058efa96e24e953ed2292cba6379e90f Merge pull request #4845 from 9rnsr/fix14838

[REG 2.066] Issue 14838 - Wrong attribute inference for auto-generated class destructor with static array of non-POD type

--
July 30, 2015
https://issues.dlang.org/show_bug.cgi?id=14838

--- Comment #8 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/d167403e777bcf91c50a7fd8eedf5100ac1ab50d
fix Issue 14838 - Wrong attribute inference for auto-generated class destructor
with static array of non-POD type

https://github.com/D-Programming-Language/dmd/commit/7e531002058efa96e24e953ed2292cba6379e90f Merge pull request #4845 from 9rnsr/fix14838

--
August 04, 2015
https://issues.dlang.org/show_bug.cgi?id=14838

Kenji Hara <k.hara.pg@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vlevenfeld@gmail.com

--- Comment #9 from Kenji Hara <k.hara.pg@gmail.com> ---
*** Issue 14239 has been marked as a duplicate of this issue. ***

--
« First   ‹ Prev
1 2