https://issues.dlang.org/show_bug.cgi?id=14842

Martin Nowak <code@dawg.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |code@dawg.eu
           Hardware|x86_64                      |All
                 OS|FreeBSD                     |All
           Severity|enhancement                 |regression

--

https://issues.dlang.org/show_bug.cgi?id=14842

Илья Ярошенко <ilyayaroshenko@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ilyayaroshenko@gmail.com

--- Comment #1 from Илья Ярошенко <ilyayaroshenko@gmail.com> ---
This function should be restricted to floating point numbers, thought.

--

https://issues.dlang.org/show_bug.cgi?id=14842

Daniel Kozak <kozzi11@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kozzi11@gmail.com

--- Comment #2 from Daniel Kozak <kozzi11@gmail.com> ---
I agree with ilya: we should add deprecation message for non floating points numbers. This would be better than error

--

https://issues.dlang.org/show_bug.cgi?id=14842

--- Comment #3 from Kenji Hara <k.hara.pg@gmail.com> ---
Introduced in: https://github.com/D-Programming-Language/phobos/pull/3012

--

https://issues.dlang.org/show_bug.cgi?id=14842

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla@digitalmars.com

--- Comment #4 from Walter Bright <bugzilla@digitalmars.com> ---
approxEqual is intended only for floating point arguments.

--

https://issues.dlang.org/show_bug.cgi?id=14842

--- Comment #5 from Walter Bright <bugzilla@digitalmars.com> ---
https://github.com/D-Programming-Language/phobos/pull/3521

--

https://issues.dlang.org/show_bug.cgi?id=14842

Martin Nowak <code@dawg.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #6 from Martin Nowak <code@dawg.eu> ---
https://github.com/D-Programming-Language/phobos/pull/3525

--

https://issues.dlang.org/show_bug.cgi?id=14842

--- Comment #7 from github-bugzilla@puremagic.com ---
Commits pushed to stable at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/bd8ed8c13cc4a73a182d8923122c17ba4ea5e524 fix Issue 14842 - [REG 2.068-b2] approxEqual does not work with integers

- promote any comparision with integers to real

https://github.com/D-Programming-Language/phobos/commit/de8896ae753bd491adba276fe6e653945334b580 Merge pull request #3525 from MartinNowak/fix14842

fix Issue 14842 - [REG 2.068-b2] approxEqual does not work with integers

--

https://issues.dlang.org/show_bug.cgi?id=14842

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--

https://issues.dlang.org/show_bug.cgi?id=14842

--- Comment #8 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/bd8ed8c13cc4a73a182d8923122c17ba4ea5e524 fix Issue 14842 - [REG 2.068-b2] approxEqual does not work with integers

https://github.com/D-Programming-Language/phobos/commit/de8896ae753bd491adba276fe6e653945334b580 Merge pull request #3525 from MartinNowak/fix14842

--