https://issues.dlang.org/show_bug.cgi?id=15215

Shriramana Sharma <samjnaa@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--

https://issues.dlang.org/show_bug.cgi?id=15215

Vladimir Panteleev <thecybershadow@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thecybershadow@gmail.com
           Assignee|nobody@puremagic.com        |thecybershadow@gmail.com

--

https://issues.dlang.org/show_bug.cgi?id=15215

Vladimir Panteleev <thecybershadow@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #1 from Vladimir Panteleev <thecybershadow@gmail.com> ---
https://github.com/D-Programming-Language/phobos/pull/3728

--

https://issues.dlang.org/show_bug.cgi?id=15215

hsteoh@quickfur.ath.cx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hsteoh@quickfur.ath.cx

--- Comment #2 from hsteoh@quickfur.ath.cx ---
Whoa, just realized that https://issues.dlang.org/show_bug.cgi?id=15695 is a duplicate of this bug, and I submitted a fix for it without realizing that https://github.com/D-Programming-Language/phobos/pull/3728 is essentially the same fix!

Anyway... since the fix has been checked in, can this be closed now?

--

https://issues.dlang.org/show_bug.cgi?id=15215

--- Comment #3 from Vladimir Panteleev <thecybershadow@gmail.com> ---
Yes assuming your PR is a superset of this one I guess.

--

https://issues.dlang.org/show_bug.cgi?id=15215

--- Comment #4 from hsteoh@quickfur.ath.cx ---
I dunno, the unittest in my PR is a bit hackish. Maybe you should rebase your PR and checkout the better unittests?

--

https://issues.dlang.org/show_bug.cgi?id=15215

--- Comment #5 from hsteoh@quickfur.ath.cx ---
I mean *checkin*.

--

https://issues.dlang.org/show_bug.cgi?id=15215

--- Comment #6 from Vladimir Panteleev <thecybershadow@gmail.com> ---
My hands are a bit full these days, sorry...

--

https://issues.dlang.org/show_bug.cgi?id=15215

Steven Schveighoffer <schveiguy@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |schveiguy@yahoo.com

--- Comment #7 from Steven Schveighoffer <schveiguy@yahoo.com> ---
(In reply to hsteoh from comment #4)
> I dunno, the unittest in my PR is a bit hackish. Maybe you should rebase your PR and checkout the better unittests?

Maybe new PR with unit tests? Let the auto-tester do the work ;)

--

https://issues.dlang.org/show_bug.cgi?id=15215

Andrei Alexandrescu <andrei@erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |andrei@erdani.com
         Resolution|---                         |FIXED

--- Comment #8 from Andrei Alexandrescu <andrei@erdani.com> ---
Current output:

Testing string: 2A
to!ubyte  : Unexpected 'A' when converting from type string to type ubyte
to!ushort : Unexpected 'A' when converting from type string to type ushort
to!uint   : Unexpected 'A' when converting from type string to type uint
to!ulong  : Unexpected 'A' when converting from type string to type ulong
to!byte   : Unexpected 'A' when converting from type string to type byte
to!short  : Unexpected 'A' when converting from type string to type short
to!int    : Unexpected 'A' when converting from type string to type int
to!long   : Unexpected 'A' when converting from type string to type long

Testing string: -2A
to!ubyte  : Unexpected '-' when converting from type string to type uint
to!ushort : Unexpected '-' when converting from type string to type uint
to!uint   : Unexpected '-' when converting from type string to type uint
to!ulong  : Unexpected '-' when converting from type string to type ulong
to!byte   : Unexpected 'A' when converting from type string to type byte
to!short  : Unexpected 'A' when converting from type string to type short
to!int    : Unexpected 'A' when converting from type string to type int
to!long   : Unexpected 'A' when converting from type string to type long

Testing string: #2A
to!ubyte  : Unexpected '#' when converting from type string to type uint
to!ushort : Unexpected '#' when converting from type string to type uint
to!uint   : Unexpected '#' when converting from type string to type uint
to!ulong  : Unexpected '#' when converting from type string to type ulong
to!byte   : Unexpected '#' when converting from type string to type int
to!short  : Unexpected '#' when converting from type string to type int
to!int    : Unexpected '#' when converting from type string to type int
to!long   : Unexpected '#' when converting from type string to type long

--