Thread overview
[Issue 16218] Windows std.file.readImpl should be marked @system
Dec 27, 2016
greenify
Jul 30, 2021
Vlăduț Chicoș
Aug 01, 2021
Dlang Bot
Aug 02, 2021
anonymous4
Aug 02, 2021
Dlang Bot
December 27, 2016
https://issues.dlang.org/show_bug.cgi?id=16218

greenify <greeenify@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |trivial
                 CC|                            |greeenify@gmail.com

--
July 30, 2021
https://issues.dlang.org/show_bug.cgi?id=16218

Vlăduț Chicoș <vladut.chicos@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vladut.chicos@gmail.com
           Assignee|nobody@puremagic.com        |vladut.chicos@gmail.com

--
August 01, 2021
https://issues.dlang.org/show_bug.cgi?id=16218

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #1 from Dlang Bot <dlang-bot@dlang.rocks> ---
@vladchicos created dlang/phobos pull request #8184 "[DSSv3] Fix Issue 16218 - Windows std.file.readImpl should be marked @system" fixing this issue:

- Fix Issue 16218 - Windows std.file.readImpl should be marked @system.

https://github.com/dlang/phobos/pull/8184

--
August 02, 2021
https://issues.dlang.org/show_bug.cgi?id=16218

--- Comment #2 from anonymous4 <dfj1esp02@sneakemail.com> ---
The "private @trusted" pattern is sort of a gray zone, it's used here for
safety inference. If readImpl was @system, all users will have to carefully
infer attributes, which is error-prone. That said, the huge trusted islands
make no sense indeed, whole readImpl should be a normal @trusted function, like
the posix variant. It takes a pointer, because tempCString returns a voldemort
type which is needlessly templated on the source range type.
BTW messing with trusted code is a rather cruel task for DSS.

--
August 02, 2021
https://issues.dlang.org/show_bug.cgi?id=16218

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/phobos pull request #8184 "[DSSv3] Fix Issue 16218 - Windows std.file.readImpl should be marked @system" was merged into master:

- f3be11dc2930cd6f500ec816f426de9b98c84eec by vladchicos:
  Fix Issue 16218 - Windows std.file.readImpl should be marked @system.

https://github.com/dlang/phobos/pull/8184

--