Thread overview
[Issue 17108] Associative array byKeyValue is unsafe
Jan 19, 2017
Jack Stouffer
Oct 03, 2017
Lucia Cojocaru
January 19, 2017
https://issues.dlang.org/show_bug.cgi?id=17108

Jack Stouffer <jack@jackstouffer.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |safe

--
March 09, 2017
https://issues.dlang.org/show_bug.cgi?id=17108

hsteoh@quickfur.ath.cx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hsteoh@quickfur.ath.cx

--- Comment #1 from hsteoh@quickfur.ath.cx ---
Hmph. This is caused by the last line in object.byKeyValue()():

----
/usr/src/d/druntime/import/object.d(2071): Error: cast from int[string] to
void* not allowed in safe code
test.d(4): Error: template instance object.byKeyValue!(int[string], string,
int) error instantiating
----

Could this be a regression?  I vaguely recall casting to void* used to be allowed, you just can't dereference it unless you're in @trusted land.

--
March 09, 2017
https://issues.dlang.org/show_bug.cgi?id=17108

--- Comment #2 from hsteoh@quickfur.ath.cx ---
Bah. Regardless of whether the void* cast is allowed or not, _aaRange() is @system so it's still a no-go.

--
October 03, 2017
https://issues.dlang.org/show_bug.cgi?id=17108

Lucia Cojocaru <lucia.mcojocaru@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucia.mcojocaru@gmail.com
           Assignee|nobody@puremagic.com        |lucia.mcojocaru@gmail.com

--
October 03, 2017
https://issues.dlang.org/show_bug.cgi?id=17108

Steven Schveighoffer <schveiguy@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://issues.dlang.org/sh
                   |                            |ow_bug.cgi?id=17507

--
November 06, 2017
https://issues.dlang.org/show_bug.cgi?id=17108

--- Comment #3 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/druntime

https://github.com/dlang/druntime/commit/51003a398b77eca1b01138412f2e363c38172878 fix issue 17108 Associative array byKeyValue is unsafe

https://github.com/dlang/druntime/commit/3bf2559ce08d449d8d486a4df3f74343f5b70b33 Merge pull request #1944 from somzzz/make_foreach_byKeyValue_safe

fix issue 17108 Associative array byKeyValue is unsafe

--
November 06, 2017
https://issues.dlang.org/show_bug.cgi?id=17108

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--
December 18, 2017
https://issues.dlang.org/show_bug.cgi?id=17108

--- Comment #4 from github-bugzilla@puremagic.com ---
Commits pushed to stable at https://github.com/dlang/druntime

https://github.com/dlang/druntime/commit/51003a398b77eca1b01138412f2e363c38172878 fix issue 17108 Associative array byKeyValue is unsafe

https://github.com/dlang/druntime/commit/3bf2559ce08d449d8d486a4df3f74343f5b70b33 Merge pull request #1944 from somzzz/make_foreach_byKeyValue_safe

--