[Issue 17308] [TEST/PROCESS] Beta releases should not be built with -release

[Issue 17308] [TEST/PROCESS] Figure out a way to test assertions in DMD more broadly

Jul 28, 2017

Jul 29, 2017

Dec 17, 2022

https://issues.dlang.org/show_bug.cgi?id=17308 Iain Buclaw <ibuclaw@gdcproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ibuclaw@gdcproject.org --

https://issues.dlang.org/show_bug.cgi?id=17308 Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> --- > Beta releases should not be built with -release Err, no, beta releases should be as close as possible to the final release. I've lost count of the number of times I shipped a broken build of some project only because the bug was not reproducible in the debug version. So, I'm pretty sure having different build flags for betas and releases a bad idea. Nightly builds are a different story and I think could be built with assertions. I'm closing this as WONTFIX as I'm pretty sure the issue as stated would be a bad idea, but please reopen if you can argument the opposite or can suggest some other actionable way to improve the situation. --

July 28, 2017

[Issue 17308] [TEST/PROCESS] Beta releases should not be built with -release

Posted by Iain Buclaw

Permalink

Iain Buclaw

Permalink

https://issues.dlang.org/show_bug.cgi?id=17308

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |---

--- Comment #2 from Iain Buclaw <ibuclaw@gdcproject.org> ---
(In reply to Vladimir Panteleev from comment #1)
> > Beta releases should not be built with -release
> 
> Err, no, beta releases should be as close as possible to the final release. I've lost count of the number of times I shipped a broken build of some project only because the bug was not reproducible in the debug version. So, I'm pretty sure having different build flags for betas and releases a bad idea.
> 
> Nightly builds are a different story and I think could be built with assertions.
> 
> I'm closing this as WONTFIX as I'm pretty sure the issue as stated would be a bad idea, but please reopen if you can argument the opposite or can suggest some other actionable way to improve the situation.

I feel inclined to re-open.  But only because I'm constantly finding bugs in the compiler.  The fact that I'm still using the C++ frontend just makes it that more evident.

Here's another one: https://issues.dlang.org/show_bug.cgi?id=17492

--

https://issues.dlang.org/show_bug.cgi?id=17308 greenify <greeenify@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |greeenify@gmail.com --- Comment #3 from greenify <greeenify@gmail.com> --- I think this issue should be more about keeping asserts like DIP1006 suggested: https://github.com/dlang/DIPs/blob/master/DIPs/DIP1006.md See also: https://github.com/dlang/dmd/pull/6103 --

https://issues.dlang.org/show_bug.cgi?id=17308 Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> --- (In reply to Iain Buclaw from comment #2) > I feel inclined to re-open. But only because I'm constantly finding bugs in the compiler. The fact that I'm still using the C++ frontend just makes it that more evident. I suggest that you find another way to achieve this goal. Here are some ideas: - Run the test suite without -release, if it's not being run that way yet - Build nightlies without -release - If the performance impact isn't too bad, just ship the release versions of DMD without -release. As stated, for reasons explained above, this issue is a Really Bad Idea. We already have enough trouble with the default build flags not matching up with what's shipped (mainly fPIC-related). --

https://issues.dlang.org/show_bug.cgi?id=17308 --- Comment #5 from Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> --- (In reply to Iain Buclaw from comment #2) > I feel inclined to re-open. But only because I'm constantly finding bugs in the compiler. The fact that I'm still using the C++ frontend just makes it that more evident. (To clarify - the above does further support the problem, however it does nothing to defend the solution you're proposing and the problems it would bring. See my message above) --

https://issues.dlang.org/show_bug.cgi?id=17308 --- Comment #7 from Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> --- (In reply to Vladimir Panteleev from comment #4) > Here are some ideas: One more: Use a DMD built without -release for the project tester, so that we test "real-life code" from community projects, instead of just our minimized test suite. --

Forums