Jump to page: 1 2
Thread overview
[Issue 17697] Ddoc: get rid of `_` detection in URLs
Jul 26, 2017
Walter Bright
Jul 26, 2017
Adam D. Ruppe
Jul 27, 2017
Vladimir Panteleev
Jul 28, 2017
Walter Bright
Jul 28, 2017
Adam D. Ruppe
[Issue 17697] Ddoc: automatically highlight URLs outside of macro arguments
Jul 29, 2017
Walter Bright
Jul 29, 2017
Walter Bright
Jul 30, 2017
Walter Bright
Mar 21, 2020
Basile-z
July 26, 2017
https://issues.dlang.org/show_bug.cgi?id=17697

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ddoc

--
July 26, 2017
https://issues.dlang.org/show_bug.cgi?id=17697

Adam D. Ruppe <destructionator@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |destructionator@gmail.com

--- Comment #1 from Adam D. Ruppe <destructionator@gmail.com> ---
The correct solution is to get rid of the utterly counterproductive identifier highlighting entirely, then remove the useless _ suppression entirely.

--
July 27, 2017
https://issues.dlang.org/show_bug.cgi?id=17697

--- Comment #2 from Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> ---
(In reply to Adam D. Ruppe from comment #1)
> The correct solution is to get rid of the utterly counterproductive identifier highlighting entirely, then remove the useless _ suppression entirely.

We only need to restrict it to $(D ...) or `backtick` blocks, as any identifiers that would benefit from being highlighted would need to be there anyway.

--
July 28, 2017
https://issues.dlang.org/show_bug.cgi?id=17697

--- Comment #3 from Walter Bright <bugzilla@digitalmars.com> ---
An even better solution is for Ddoc to recognize URLs and wrap them automatically in $(LINK ) macros. This will also resolve the leading _ problem in URLs.

--
July 28, 2017
https://issues.dlang.org/show_bug.cgi?id=17697

--- Comment #4 from Adam D. Ruppe <destructionator@gmail.com> ---
The highlight thing and _ treatment happens in macros too...

--
July 29, 2017
https://issues.dlang.org/show_bug.cgi?id=17697

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Ddoc: get rid of `_`        |Ddoc: automatically
                   |detection in URLs           |highlight URLs outside of
                   |                            |macro arguments

--
July 29, 2017
https://issues.dlang.org/show_bug.cgi?id=17697

--- Comment #5 from Walter Bright <bugzilla@digitalmars.com> ---
https://github.com/dlang/dmd/pull/7043

--
July 30, 2017
https://issues.dlang.org/show_bug.cgi?id=17697

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b2.temp@gmx.com

--- Comment #6 from Walter Bright <bugzilla@digitalmars.com> ---
*** Issue 17704 has been marked as a duplicate of this issue. ***

--
July 31, 2017
https://issues.dlang.org/show_bug.cgi?id=17697

--- Comment #7 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/f100182bbde9496063c223fab2880a901be29880 fix Issue 17697 - Ddoc: automatically highlight URLs outside of macro arguments

https://github.com/dlang/dmd/commit/d15072fc64c1d59ac107834a3c2738919a243002 Merge pull request #7043 from WalterBright/fix17697

fix Issue 17697 - Ddoc: automatically highlight URLs outside of macro… merged-on-behalf-of: Walter Bright <WalterBright@users.noreply.github.com>

--
July 31, 2017
https://issues.dlang.org/show_bug.cgi?id=17697

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--
« First   ‹ Prev
1 2