Thread overview
[Issue 17847]=?UTF-8?Q?=20Properly=20sanitize=20seeds=20for=20Park=E2=80=93Miller=20engines?=
Sep 21, 2017
Nathan S.
September 21, 2017
https://issues.dlang.org/show_bug.cgi?id=17847

--- Comment #1 from Nathan S. <natesash@gmail.com> ---
Fixed by https://github.com/dlang/phobos/pull/5743

--
September 25, 2017
https://issues.dlang.org/show_bug.cgi?id=17847

--- Comment #2 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/fd2e5ba03c2c1304dd516a32e2659c3ed01c1936 Fix Issue 17847 - Properly sanitize seeds for Park–Miller engines

As in XorshiftEngine, sanitizing the seed is more useful than throwing an exception. The original check was broken because it checked the seed before taking the modulus. Making this change allows unpredictableSeed to be marked nothrow and @nogc.

https://github.com/dlang/phobos/commit/218434f4b72bd4b8616214a615fe8cd433c6efe0 Merge pull request #5743 from n8sh/fix-random-lcg

Fix Issue 17847 - Properly sanitize seeds for Park–Miller engines merged-on-behalf-of: Dmitry Olshansky <dmitry@olshansky.me>

--
September 25, 2017
https://issues.dlang.org/show_bug.cgi?id=17847

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--
October 16, 2017
https://issues.dlang.org/show_bug.cgi?id=17847

--- Comment #3 from github-bugzilla@puremagic.com ---
Commits pushed to stable at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/fd2e5ba03c2c1304dd516a32e2659c3ed01c1936 Fix Issue 17847 - Properly sanitize seeds for Park–Miller engines

https://github.com/dlang/phobos/commit/218434f4b72bd4b8616214a615fe8cd433c6efe0 Merge pull request #5743 from n8sh/fix-random-lcg

--