Thread overview
[Issue 21218] dtoh: protection attributes should be emitted to headers
Sep 03
Seb
Sep 28
Dlang Bot
Oct 15
Dlang Bot
September 03
https://issues.dlang.org/show_bug.cgi?id=21218

Seb <greeenify@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|dtoh: protected attribute   |dtoh: protection attributes
                   |should be emitted to        |should be emitted to
                   |headers                     |headers

--- Comment #1 from Seb <greeenify@gmail.com> ---
This also applies to `private` and likely all other protection attributes:

```
extern(C++) struct Foo {
  private int a = 1;
}
```

generates currently:

```
struct Foo
{
    int32_t a;
    Foo() {}
};
```

--
September 28
https://issues.dlang.org/show_bug.cgi?id=21218

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #2 from Dlang Bot <dlang-bot@dlang.rocks> ---
@MoonlightSentinel created dlang/dmd pull request #11804 "Fix 21218 - protection attributes should be emitted to C++ headers" fixing this issue:

- Fix 21218 - protection attributes should be emitted to C++ headers

  Properly track the current protection while writing struct/class members
  and add `public:`, `protected:` or `private:` as necessary.

  `package` and `package(...)` is currently mapped to `protected` as there
  is no real equivalent in C++.

https://github.com/dlang/dmd/pull/11804

--
October 15
https://issues.dlang.org/show_bug.cgi?id=21218

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #11804 "Fix 21218 - protection attributes should be emitted to C++ headers" was merged into master:

- f0ebacdb3b8e91cbeb42ed86f2123dada7f68658 by MoonlightSentinel:
  Fix 21218 - protection attributes should be emitted to C++ headers

  Properly track the current protection while writing struct/class members
  and add `public:`, `protected:` or `private:` as necessary.

  `package` and `package(...)` is currently mapped to `protected` as there
  is no real equivalent in C++.

https://github.com/dlang/dmd/pull/11804

--