https://issues.dlang.org/show_bug.cgi?id=21505

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #1 from Dlang Bot <dlang-bot@dlang.rocks> ---
@MoonlightSentinel updated dlang/dmd pull request #12053 "Fix duplicate function detection for overloads introduced by aliases" fixing this issue:

- Fix 21505 - Rework duplicate function detection without mangling

  The previous implementation compared small parts of the function mangling
  to detect duplicate functions. This approach had several flaws manifesting
  in the referenced issue as well as other false positives for (static)
  members, `alias`ing into different scopes, ... .

  Issue 21505 was caused by the assumption that all functions visited by
  `overloadApply` have the same name. This doesn't hold for overloads
  introduced by an `alias`.

  A reliable mangling-based implementation would need to compare most of
  the mangled name while also omitting severel aspects e.g. the return type
  to detect `int foo()` and `void foo()`.

  Hence the current implementation was replaced by actually comparing the
  `FuncDeclaration`s because it allows for more fine grained checks (and
  also should save some memory allocations).

https://github.com/dlang/dmd/pull/12053

--

https://issues.dlang.org/show_bug.cgi?id=21505

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #12053 "Fix duplicate function detection for overloads introduced by aliases" was merged into stable:

- 487e32082ebe51abee747200e4071b4f58b35957 by MoonlightSentinel:
  Fix 21505 - Rework duplicate function detection without mangling

  The previous implementation compared small parts of the function mangling
  to detect duplicate functions. This approach had several flaws manifesting
  in the referenced issue as well as other false positives for (static)
  members, `alias`ing into different scopes, ... .

  Issue 21505 was caused by the assumption that all functions visited by
  `overloadApply` have the same name. This doesn't hold for overloads
  introduced by an `alias`.

  A reliable mangling-based implementation would need to compare most of
  the mangled name while also omitting severel aspects e.g. the return type
  to detect `int foo()` and `void foo()`.

  Hence the current implementation was replaced by actually comparing the
  `FuncDeclaration`s because it allows for more fine grained checks (and
  also should save some memory allocations).

https://github.com/dlang/dmd/pull/12053

--

https://issues.dlang.org/show_bug.cgi?id=21505

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #12195 "Merge stable" was merged into master:

- 41fa5138bc8aebcf9ab4870c4df19e42e1f97d80 by Florian:
  Fix 21505 - Rework duplicate function detection without mangling (#12053)

  The previous implementation compared small parts of the function mangling
  to detect duplicate functions. This approach had several flaws manifesting
  in the referenced issue as well as other false positives for (static)
  members, `alias`ing into different scopes, ... .

  Issue 21505 was caused by the assumption that all functions visited by
  `overloadApply` have the same name. This doesn't hold for overloads
  introduced by an `alias`.

  A reliable mangling-based implementation would need to compare most of
  the mangled name while also omitting severel aspects e.g. the return type
  to detect `int foo()` and `void foo()`.

  Hence the current implementation was replaced by actually comparing the
  `FuncDeclaration`s because it allows for more fine grained checks (and
  also should save some memory allocations).

https://github.com/dlang/dmd/pull/12195

--