https://issues.dlang.org/show_bug.cgi?id=21932

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ibuclaw@gdcproject.org

--- Comment #1 from Iain Buclaw <ibuclaw@gdcproject.org> ---
(In reply to Iain Buclaw from comment #0)
> The parser allows implicit typedefs, which is not valid C.
> ---
> struct STRUCT { void *opaque; };
> STRUCT mystruct;  // Should error.
> ---
This is probably not so easily solvable though, as the error should happen in the semantic (but the semantic follows D rules!)

The immediate issue should focus on getting `struct S s;` working.

--

https://issues.dlang.org/show_bug.cgi?id=21932

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |importC

--

https://issues.dlang.org/show_bug.cgi?id=21932

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |accepts-invalid,
                   |                            |rejects-valid

--

https://issues.dlang.org/show_bug.cgi?id=21932

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla@digitalmars.com

--- Comment #2 from Walter Bright <bugzilla@digitalmars.com> ---
This is actually how C++ works, and it compiles C fine.

It is not rigorous C, to be sure, but I think we're all right with it.

--

https://issues.dlang.org/show_bug.cgi?id=21932

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|accepts-invalid             |

--- Comment #3 from Iain Buclaw <ibuclaw@gdcproject.org> ---
(In reply to Walter Bright from comment #2)
> This is actually how C++ works, and it compiles C fine.
> 
> It is not rigorous C, to be sure, but I think we're all right with it.

Yeah, I'll removed the accepts-invalid tag.  In principle there's nothing wrong will accepting more than what a typical C compiler would so long as it can be justified.

--

https://issues.dlang.org/show_bug.cgi?id=21932

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|importC: struct 'STRUCT'    |importC: enum 'ENUM'
                   |conflicts with struct       |conflicts with enum 'ENUM'
                   |'STRUCT'                    |

--

https://issues.dlang.org/show_bug.cgi?id=21932

--- Comment #4 from Iain Buclaw <ibuclaw@gdcproject.org> ---
The struct test case has been fixed with the introduction of TypeTag.

The enum test case still fails, however.

---
enum ENUM { ENUM_a };
enum ENUM myenum;  // Error

--

https://issues.dlang.org/show_bug.cgi?id=21932

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #5 from Dlang Bot <dlang-bot@dlang.rocks> ---
@ibuclaw created dlang/dmd pull request #12723 "fix Issue 21932, 22060 - importC: Multiple forward declarations result in error struct conflicts with struct" fixing this issue:

- fix Issue 21932 - importC: enum 'ENUM' conflicts with enum 'ENUM'

https://github.com/dlang/dmd/pull/12723

--

https://issues.dlang.org/show_bug.cgi?id=21932

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|pull                        |

--

https://issues.dlang.org/show_bug.cgi?id=21932

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #6 from Dlang Bot <dlang-bot@dlang.rocks> ---
@WalterBright created dlang/dmd pull request #12787 "fix Issue 21932 ImportC: enum ENUM conflicst with enum ENUM" fixing this issue:

- fix Issue 21932 ImportC: enum ENUM conflicst with enum ENUM

https://github.com/dlang/dmd/pull/12787

--