https://bugzilla.gdcproject.org/show_bug.cgi?id=302

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Iain Buclaw <ibuclaw@gdcproject.org> ---
> Should work according to D spec at https://dlang.org/spec/declaration.html#BasicType2X function type, but does not.

Nope, the error is correct and in accordance to the spec.  Only built-in attributes are allowed as postfixes - UDAs are not built-in.


> @attribute("ms_abi") size_t function(int, int) foo; // Example, calling does not use ms_abi

That could be a failing of the front-end to propagate UDAs to variables.

https://github.com/D-Programming-GDC/GDC/blob/c2fc3dbf5dc844583344f9cc6e1d4ba32bd736bf/gcc/d/decl.cc#L1321-L1328

I'll have to check.

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugzilla.gdcproject.org/show_bug.cgi?id=302

--- Comment #2 from ARaspiK <araspik@protonmail.com> ---
Oh, OK. Thanks for responding so fast.

About that section: I have no idea what it does, but I think it looks right.
I'me reading it as "If userAttributes, getAttributes, then
`decl_attributes(csym, build_attributes(getAttributes)`"
There might be something at the `decl_attributes`, but it looks okay. Not sure
why this is happening.

Could it be that the attribute is affecting the storage space and not the function pointer?

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugzilla.gdcproject.org/show_bug.cgi?id=302

--- Comment #3 from Iain Buclaw <ibuclaw@gdcproject.org> ---
OK, looks like ms_abi is an attribute of the function type, not the declaration itself, and this attribute information gets lost when calling the variable, as the original type gets cast away.

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugzilla.gdcproject.org/show_bug.cgi?id=302

--- Comment #4 from Iain Buclaw <ibuclaw@gdcproject.org> ---
Perhaps rather than using `@attribute("ms_abi")` we could extend
`extern(Windows)` instead to have a special meaning on 64bit.


extern(Windows) size_t function(int, int) foo;  // Marked as 'ms_abi'.

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugzilla.gdcproject.org/show_bug.cgi?id=302

--- Comment #5 from ARaspiK <araspik@protonmail.com> ---
Perhaps a new extern(MS_ABI) or similar is needed. After all, the spec has
declared extern(Windows) to be the same as extern(C) except in case of 32-bit,
where it then uses stdcall.

On other vendors, LDC will use ms_abi when compiled with -mtriple=x86_64-unknown-windows-coff, where ms_abi is specified with extern(C).

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugzilla.gdcproject.org/show_bug.cgi?id=302

--- Comment #6 from Iain Buclaw <ibuclaw@gdcproject.org> ---
(In reply to ARaspiK from comment #5)
> Perhaps a new extern(MS_ABI) or similar is needed. After all, the spec has
> declared extern(Windows) to be the same as extern(C) except in case of
> 32-bit, where it then uses stdcall.
> 

I'm not sure if it does warrant a new calling convention, but I can see that there needs to be more careful handling of gcc type attributes through the codegen pass.  Though only function types are really affected, other kinds of type either have their own unique type decl (struct, class, enum), or we don't expose any kind of type attributes to because the language has a feature that provides for it (i.e vector attributes).

Such examples of careful handling includes emitting a warning if you assign a function with type attributes to a function pointer that has none.  Of course, if this information is part of the function type linkage in the frontend, then a compiler error will happen before the codegen stage.

Alternatively we could start disallowing assigning type attributes to functions, as there's no simple way to ensure that it will stick.

Explanation:

// Frontend attaches @ms_abi to the fdecl and fptr declarations.
// GCC codegen attaches them to the type, creating a new type variant.
@ms_abi T fdecl();
@ms_abi T function() fptr = &fdecl;

// Frontend will pass the equivalent code: (cast(T)*fptr)();
// Where T is original function type without attributes.
// This is where the information is getting lost.
fptr();


> On other vendors, LDC will use ms_abi when compiled with -mtriple=x86_64-unknown-windows-coff, where ms_abi is specified with extern(C).

That is the same for gcc also. The suggestion makes a difference only for non-windows platforms.

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugzilla.gdcproject.org/show_bug.cgi?id=302

--- Comment #7 from ARaspiK <araspik@protonmail.com> ---
Also, this fails too, not just postfixes:
module test;

import gcc.attribute;

alias func = @attribute("ms_abi") void function(int, int);

func foo;

void main() {
  foo(2, 4);
}

gdc test.d -c -o test.o
test.d:5:35: error: user defined attributes not allowed for alias declarations
 alias func = @attribute("ms_abi") void function(int, int);
                                   ^

At least some UDAs should be allowed.

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugzilla.gdcproject.org/show_bug.cgi?id=302

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ibuclaw@gdcproject.org
            Summary|`function` type UDA         |UDA @attributes can not be
                   |postfixes not allowed       |applied to function types

-- 
You are receiving this mail because:
You are watching all bug changes.