https://issues.dlang.org/show_bug.cgi?id=4831

Jonathan Marler <johnnymarler@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johnnymarler@gmail.com

--

https://issues.dlang.org/show_bug.cgi?id=4831

--- Comment #9 from Jonathan Marler <johnnymarler@gmail.com> ---
Created potential workaround.  Pull request here:

https://github.com/DigitalMars/optlink/pull/16

--

https://issues.dlang.org/show_bug.cgi?id=4831

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Walter Bright <bugzilla@digitalmars.com> ---
https://github.com/DigitalMars/optlink/commit/7c096397c052b209cb2cdf2dbe238fecd482239a

--

https://issues.dlang.org/show_bug.cgi?id=4831

9999 <mailnew4ster@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mailnew4ster@gmail.com

--- Comment #11 from 9999 <mailnew4ster@gmail.com> ---
Seems like the merged pull is only a workaround. Why not pull the real fix
instead?
https://github.com/DigitalMars/optlink/pull/1

--

https://issues.dlang.org/show_bug.cgi?id=4831

--- Comment #12 from Andrej Mitrovic <andrej.mitrovich@gmail.com> ---
(In reply to 9999 from comment #11)
> Seems like the merged pull is only a workaround. Why not pull the real fix
> instead?
> https://github.com/DigitalMars/optlink/pull/1

I don't think my fix was fully complete.

--

https://issues.dlang.org/show_bug.cgi?id=4831

--- Comment #13 from Jonathan Marler <johnnymarler@gmail.com> ---
Andrei I believe he's referring to my PR. The issue described by the description of this bug was fixed (having '+' signs in the path), however, based on the title I'm not sure it fixed everything.  If there are any other characters in the path that would cause optlink to fail I can take a look.  Do you know of any more cases to test?

Also, it is a workaround because optlink now ignores any paths containing a '+' character.  I believe that making optlink accept paths with '+' character may be a much bigger change.  I didn't want my first contribution to optlink to be too big so I opted for the workaround (which was around 15 lines of code). Maybe I'll spend some time on this problem later.  If you have any more dire issues post them here.

--

https://issues.dlang.org/show_bug.cgi?id=4831

Andrei Alexandrescu <andrei@erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Optlink                     |tools

--

https://issues.dlang.org/show_bug.cgi?id=4831

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Optlink

--