Thread overview
[Issue 5096] More readable unpaired brace error
Feb 15, 2020
Adam D. Ruppe
Jan 18, 2022
Adam D. Ruppe
Jan 20, 2022
Dlang Bot
Jan 20, 2022
Dlang Bot
August 07, 2014
https://issues.dlang.org/show_bug.cgi?id=5096

hsteoh@quickfur.ath.cx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hsteoh@quickfur.ath.cx

--
February 15, 2020
https://issues.dlang.org/show_bug.cgi?id=5096

Adam D. Ruppe <destructionator@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |destructionator@gmail.com
           Severity|minor                       |enhancement

--- Comment #1 from Adam D. Ruppe <destructionator@gmail.com> ---
Just wasted ~ 5 mins due to this.

struct Foo {
        void foo() {
                if(1)
                        assert(0);
                }
        }
}

enhance.d(7): Error: unrecognized declaration


Of course in my real code it reported

terminal.d(1681): Error: unrecognized declaration

turns out on line 943, I wrote `void thing() { if() .... } } `. missing the
opening { on the if


Yes, 700 lines apart in the real thing.


Perhaps you say this belongs in a linter but this could have been detected perhaps by seeing the close brace isn't on the same indent as its corresponding open line (not always true but can maybebe worth a warning anyway)

--
January 18, 2022
https://issues.dlang.org/show_bug.cgi?id=5096

--- Comment #2 from Adam D. Ruppe <destructionator@gmail.com> ---
This struck me AGAIN last week. I copy/pasted some code to shuffle things into a nested function and brought in an extra }. The first error message issued was *hundreds of lines* past the actual error, then the remaining ones even further out.

--
January 20, 2022
https://issues.dlang.org/show_bug.cgi?id=5096

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
@benjones created dlang/dmd pull request #13552 "fix issue 5096: bad unmatched closing brace messages" fixing this issue:

- fix issue 5096: bad unmatched closing brace messages

https://github.com/dlang/dmd/pull/13552

--
January 20, 2022
https://issues.dlang.org/show_bug.cgi?id=5096

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #13552 "fix issue 5096: bad unmatched closing brace messages" was merged into master:

- 53bad75bf8d40bcf32551715df3a8a7e2eb764d8 by Ben Jones:
  fix issue 5096: bad unmatched closing brace messages

https://github.com/dlang/dmd/pull/13552

--