Jump to page: 1 2
Thread overview
[Issue 5995] string append negative integer causes segfault
Apr 09, 2015
erictsau@gmail.com
Nov 22, 2016
Lucia Cojocaru
Nov 22, 2016
Lucia Cojocaru
Nov 22, 2016
Lucia Cojocaru
Nov 24, 2016
Lucia Cojocaru
Jul 05, 2017
Vladimir Panteleev
June 06, 2014
https://issues.dlang.org/show_bug.cgi?id=5995

briancschott@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |briancschott@gmail.com

--- Comment #9 from briancschott@gmail.com ---
Still present in 2.065.

--
September 11, 2014
https://issues.dlang.org/show_bug.cgi?id=5995

hsteoh@quickfur.ath.cx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hsteoh@quickfur.ath.cx

--- Comment #10 from hsteoh@quickfur.ath.cx ---
Still present in git HEAD (2.067b).

--
October 30, 2014
https://issues.dlang.org/show_bug.cgi?id=5995

--- Comment #11 from hsteoh@quickfur.ath.cx ---
Should appending invalid codepoints append the Unicode replacement character instead?

--
October 31, 2014
https://issues.dlang.org/show_bug.cgi?id=5995

--- Comment #12 from Steven Schveighoffer <schveiguy@yahoo.com> ---
(In reply to hsteoh from comment #11)
> Should appending invalid codepoints append the Unicode replacement character instead?

I think implicit casting of int to dchar should be invalid altogether. See my 2011 comment.

--
April 09, 2015
https://issues.dlang.org/show_bug.cgi?id=5995

erictsau@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |erictsau@gmail.com

--- Comment #13 from erictsau@gmail.com ---
Still present in 2.067

--
October 14, 2016
https://issues.dlang.org/show_bug.cgi?id=5995

Andrei Alexandrescu <andrei@erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bootcamp
                 CC|                            |andrei@erdani.com

--
November 22, 2016
https://issues.dlang.org/show_bug.cgi?id=5995

Lucia Cojocaru <lucia.mcojocaru@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucia.mcojocaru@gmail.com

--- Comment #14 from Lucia Cojocaru <lucia.mcojocaru@gmail.com> ---
This is a problem in the compiler.

https://github.com/dlang/dmd/blob/master/src/dcast.d#L66 https://github.com/dlang/dmd/blob/master/src/mtype.d#L4150

I will open a PR shortly to disable implicit cast of int -> dchar. Should we disable the implicit cast of all integral types to chars? For example, is it expected to make an implicit cast from uint to dchar?

(The compiler itself seems to rely on implicit casts of unit -> dchar. Compiling the compiler with this cast disabled produces some errors.)


This is also enabled: bool -> dchar. Not sure if it is desirable. Expression.implicitCastTo(z of type bool) => dchar

--
November 22, 2016
https://issues.dlang.org/show_bug.cgi?id=5995

Lucia Cojocaru <lucia.mcojocaru@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|druntime                    |dmd

--
November 22, 2016
https://issues.dlang.org/show_bug.cgi?id=5995

Lucia Cojocaru <lucia.mcojocaru@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@puremagic.com        |lucia.mcojocaru@gmail.com

--
November 22, 2016
https://issues.dlang.org/show_bug.cgi?id=5995

--- Comment #15 from Steven Schveighoffer <schveiguy@yahoo.com> ---
Lucia, I think nothing should implicitly cast to dchar. Not bool, int, or even char or wchar. But something this drastic needs approval from Walter and Andrei.

Of course, we definitely need a deprecation step before completely banning it -- this will certainly break a lot of code.

--
« First   ‹ Prev
1 2