http://d.puremagic.com/issues/show_bug.cgi?id=8153

           Summary: Warning about toHash is incorrect
           Product: D
           Version: unspecified
          Platform: x86_64
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: DMD
        AssignedTo: nobody@puremagic.com
        ReportedBy: jmdavisProg@gmx.com


--- Comment #0 from Jonathan M Davis <jmdavisProg@gmx.com> 2012-05-26 15:05:26 PDT ---


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8153


Jonathan M Davis <jmdavisProg@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Warning about toHash is     |Warning about toHash
                   |incorrect                   |signature is incorrect on
                   |                            |x86_64


--- Comment #1 from Jonathan M Davis <jmdavisProg@gmx.com> 2012-05-26 15:09:58 PDT ---
Sorry, I accidentally hit enter. Here's the bug description:
------------------------------------------------------------

This code:

struct S
{
    size_t toHash() const pure
    {
        return 42;
    }

    string val;
}

void main()
{
}


results in this error with -w:

q.d(3): Warning: toHash() must be declared as extern (D) uint toHash() const
nothrow @safe, not const pure ulong()

The _correct_ signature for toHash is

size_t toHash() @safe const pure nothrow

The warning incorrectly lists uint. It should say size_t. It should probably also say pure, but that might not be required yet given the flux that toHash, toString, opEquals, et al. are in at the moment with regards to their required attributes.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8153



--- Comment #2 from github-bugzilla@puremagic.com 2012-11-28 00:46:57 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/ea6d4d8352d0cf115b6da84a1eff7cfd81a4a623 Fix bug 8153 Warning about toHash signature is incorrect on x86_64

This is a trivial wording change.

https://github.com/D-Programming-Language/dmd/commit/38d04f8897844f17239ca0d67fdafb1273cdc05e Merge pull request #1332 from donc/toHash8153warningwording

Fix bug 8153 Warning about toHash signature is incorrect on x86_64

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8153


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |andrej.mitrovich@gmail.com
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------