Jump to page: 1 2
Thread overview
[Issue 9631] Error message not using fully qualified name when appropriate.
Jul 11, 2014
Mark Isaacson
Feb 09, 2017
Daniel Kozak
Feb 09, 2017
Daniel Kozak
Feb 10, 2017
Jack Stouffer
Feb 15, 2017
Nick Treleaven
Aug 23
Mike
July 11, 2014
https://issues.dlang.org/show_bug.cgi?id=9631

Mark Isaacson <markisaa@umich.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markisaa@umich.edu

--- Comment #6 from Mark Isaacson <markisaa@umich.edu> ---
Was just about to report this myself. Hoping that a reply draws a bit more attention. This became apparent when I accidentally imported std.json instead of the revised/improved version I have locally (and whose changes are in the next dmd release).

--
July 11, 2014
https://issues.dlang.org/show_bug.cgi?id=9631

jiki@red.email.ne.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jiki@red.email.ne.jp

--- Comment #7 from jiki@red.email.ne.jp ---
To fix this, replace each occurrence of xtype->toChars()
with xtype->toPrettyChars(true).


For instance,
 Expression *BinExp::incompatibleTypes() in dmd/src/expression.c:

 error("incompatible types for ((%s) %s (%s)): '%s' and '%s'",
         e1->toChars(), Token::toChars(thisOp), e2->toChars(),
         e1->type->toChars(), e2->type->toChars()); // <--- PATCH HERE, 2 of 2


As Comment 0,
 Expression *implicitCastTo(Expression *e, Scope *sc, Type *t) in
dmd/src/cast.c:

 e->error("cannot implicitly convert expression (%s) of type %s to %s",
         e->toChars(), e->type->Chars(), t->toChars()); // <--- PATCH HERE,
last 2 of 3


# But it isn't enough checked. :P

--
February 09, 2017
https://issues.dlang.org/show_bug.cgi?id=9631

Daniel Kozak <kozzi11@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kozzi11@gmail.com

--- Comment #8 from Daniel Kozak <kozzi11@gmail.com> ---
Bump to same error today: http://forum.dlang.org/post/xpmpakmusudanwuzzezl@forum.dlang.org

--
February 09, 2017
https://issues.dlang.org/show_bug.cgi?id=9631

--- Comment #9 from Daniel Kozak <kozzi11@gmail.com> ---
Maybe we could change this to trivial?
I belive it is not hard to fix this. I can do it my self if there is no one
else willing to do.

--
February 10, 2017
https://issues.dlang.org/show_bug.cgi?id=9631

Jack Stouffer <jack@jackstouffer.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |trivial
                 CC|                            |jack@jackstouffer.com

--
February 15, 2017
https://issues.dlang.org/show_bug.cgi?id=9631

Nick Treleaven <nick@geany.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |destructionator@gmail.com

--- Comment #10 from Nick Treleaven <nick@geany.org> ---
*** Issue 15077 has been marked as a duplicate of this issue. ***

--
May 08
https://issues.dlang.org/show_bug.cgi?id=9631

Andreas Reischuck <arbmind@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arbmind@gmail.com

--- Comment #11 from Andreas Reischuck <arbmind@gmail.com> ---
I tried to tackle this issue at DConf Hackathon.

The issue is not totally trivial. Fully qualifying all types in error messages
leads to unreadable error messages.
Imagine a function with 5 arguments, where each argument is fully qualified.

The good solution would be to detect that the error message is ambiguous and only then fall back to fully qualified types.

To do this each error has to be inspected separately. Some are more complicated, as types of expressions and arguments are generated independently right now.

I suggest to split this issue and create issues for all the situations types are reported to be ambiguous and tackle them one by one. Solving them all at once is quite an endeavor.

--
May 08
https://issues.dlang.org/show_bug.cgi?id=9631

--- Comment #12 from Adam D. Ruppe <destructionator@gmail.com> ---
> Fully qualifying all types in error messages leads to unreadable error messages.

I would say if the compiler ever sees `if(t1.toChars == t2.toChars) print
toPrettyChars instead`.

But there's another option too.... just output the unreadable error messages on a compiler switch and let external programs like IDEs filter them.

The switch could be `-v`, though I still actually really want to see XML error messages, they could list soooooo much info for ides or external filters.

--
August 23
https://issues.dlang.org/show_bug.cgi?id=9631

Mike <slavo5150@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|trivial                     |
                 CC|                            |slavo5150@yahoo.com

--
December 07
https://issues.dlang.org/show_bug.cgi?id=9631

Nick Treleaven <nick@geany.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick@geany.org

--- Comment #13 from Nick Treleaven <nick@geany.org> ---
https://github.com/dlang/dmd/pull/7405

--
« First   ‹ Prev
1 2