Menu
Search

Forums

Forum Index

Thread overview
[dmd-internals] proposed patch for #4322
Jun 16, 2010
Graham Fawcett
Jun 16, 2010
Walter Bright
Jun 16, 2010
Don Clugston
Jun 17, 2010
Graham Fawcett
June 16, 2010
Gravatar of Graham FawcettPosted by Graham FawcettReply
Graham Fawcett
Gravatar of Graham Fawcett


Reply
Hi folks,

Today I pushed a possible patch for issue #4322:

http://d.puremagic.com/issues/show_bug.cgi?id=4322

This is my first DMD patch, and I'm unclear on the protocol. Is it enough that I add the patch to the ticket? Or should I ask here on the list for a review?

Thanks,
Graham
June 16, 2010
Gravatar of Walter BrightPosted by Walter Bright
in reply to Graham Fawcett		Reply
Walter Bright
Gravatar of Walter Bright
Posted in reply to Graham Fawcett


Reply

Graham Fawcett wrote:
> Hi folks,
>
> Today I pushed a possible patch for issue #4322:
>
> http://d.puremagic.com/issues/show_bug.cgi?id=4322
>
> This is my first DMD patch, and I'm unclear on the protocol. Is it enough that I add the patch to the ticket? Or should I ask here on the list for a review?
>
> 

The patch on bugzilla is enough. Thanks!
June 16, 2010
Gravatar of Don ClugstonPosted by Don Clugston
in reply to Walter Bright		Reply
Don Clugston
Gravatar of Don Clugston
Posted in reply to Walter Bright


Reply
On 16 June 2010 23:47, Walter Bright <walter at digitalmars.com> wrote:
>
>
> Graham Fawcett wrote:
>>
>> Hi folks,
>>
>> Today I pushed a possible patch for issue #4322:
>>
>> http://d.puremagic.com/issues/show_bug.cgi?id=4322
>>
>> This is my first DMD patch, and I'm unclear on the protocol. Is it enough that I add the patch to the ticket? Or should I ask here on the list for a review?
>>
>>
>
> The patch on bugzilla is enough. Thanks!

One other important thing -- add the 'patch' keyword to the ticket. That way it shows up in the patch list.
June 17, 2010
Gravatar of Graham FawcettPosted by Graham Fawcett
in reply to Don Clugston		Reply
Graham Fawcett
Gravatar of Graham Fawcett
Posted in reply to Don Clugston


Reply
On Wed, 16 Jun 2010 23:52:24 +0200, Don Clugston wrote:

> On 16 June 2010 23:47, Walter Bright
> <walter at digitalmars.com> wrote:
>>
>>
>> Graham Fawcett wrote:
>>>
>>> Hi folks,
>>>
>>> Today I pushed a possible patch for issue #4322:
>>>
>>> http://d.puremagic.com/issues/show_bug.cgi?id=4322
>>>
>>> This is my first DMD patch, and I'm unclear on the protocol. Is it enough that I add the patch to the ticket? Or should I ask here on the list for a review?
>>>
>>>
>>>
>> The patch on bugzilla is enough. Thanks!
> 
> One other important thing -- add the 'patch' keyword to the ticket. That way it shows up in the patch list.

Done. Thanks!

Graham