View mode: basic / threaded / horizontal-split · Log in · Help
October 15, 2012
Re: Is flags enum needed in Phobos?
On Monday, 15 October 2012 at 02:54:38 UTC, bearophile wrote:
> Era Scarecrow:
>
>> I can't get opOpAssign working properly, and it's worse with 
>> arrays. Removing opOpAssign, everything else (arrays, single 
>> flags, other flags) works properly.
>
> Are such problems known? In bugzilla or here? Are those fixable?

 mmm... As I'm looking at it and making a reply, I've noticed a 
couple mistakes. Give me an hour or so to test and add it in. If 
all's well it will be fixed/added

> Are you going to create a Phobos GitHugHub pull request?

 Wasn't planning on it. If you feel the library is good enough, I 
may add a request. But more likely it will be merged with another 
file, likely std.bitmanip or something...
October 15, 2012
Re: Is flags enum needed in Phobos?
K I have opOpAssign working. I may have to clean up 
documentation a little and clean the unittests up a bit, but it 
all appears to be working.

 Feel free to give it a try.

 I have added opSlice, which returns an array of your enum of all 
the flags it qualifies for. An empty enum (say, zero) never 
qualifies as it has no bits to make it unique (or it would always 
be present no matter what).

 Mmm... I actually hope that's all that's needed for it.
October 15, 2012
Re: Is flags enum needed in Phobos?
Era Scarecrow:

> But more likely it will be merged with another file, likely 
> std.bitmanip or something...

A Phobos pull request is OK even if it's meant to be merged with 
std.bitmanip. Pull requests are not just for separate modules.

On GitHub people will be able to comment on single lines of code, 
etc.

Bye,
bearophile
Next ›   Last »
1 2 3
Top | Discussion index | About this forum | D home