View mode: basic / threaded / horizontal-split · Log in · Help
November 14, 2012
Re: [RFC] A huge problem with Github diff
On 14-11-2012 21:36, Andrej Mitrovic wrote:
> On 11/14/12, Alex Rønne Petersen <alex@lycus.org> wrote:
>> Or we could switch to Phabricator for our entire review process which
>> has an absolutely awesome side-by-side diff and is generally a fantastic
>> tool for distributed-style software projects.
>>
>> See my email to dmd-internals:
>> http://lists.puremagic.com/pipermail/dmd-internals/2012-October/004900.html
>
> I don't see what's awesome about it, for one thing the code display
> pages don't seem to be static HTML (or whatever you call it), because
> every time I enter into codeview I have to wait a few seconds for all
> the code to render. For big changes it's annoying to having to wait so
> long. And if I hit the back button and forward again, it starts to
> re-render again and I have to wait again. Clicking the show context
> can take over 5 seconds to display, and then Firefox almost freezes
> because the CPU usage keeps spiking to 90%. Pretty lame if you ask me.

Cannot reproduce in both Firefox and Chrome; code view also loads 
instantaneously for me.

>
> It's also inconsistent, my font settings I've set in the control panel
> aren't applied everywhere.

You need to manually configure your monospaced font in Phabricator in 
your display preferences. Any other font that isn't being applied 
correctly is a bug. I don't know why they do it this way for monospaced 
font, but I don't find it to be a show stopper.

>
> And what is Arcanist, it seems it's betaware like msys, except much
> less tested on Windows? Quote: "NOTE: Windows support is relatively
> new and incomplete, file bugs when you run into issues." And you even
> need to install PHP to make it work.

From what I've heard, other Phabricator/Arcanist users have no trouble 
on Windows these days. The support was very alpha quality a while back, 
but it should be fine now.

(I don't actually know. I don't use Windows.)

>
> And then there are things like making the code block button
> automatically insert some sort of PHP/Ruby code. Does it even support
> D syntax in comments?

It's just some code to demonstrate how the syntax works. Hit delete once 
and it's gone (or just don't use that button at all; why would you?).

Yes, it does support D (it uses Pygments).

>
> The last thing we need now is to make the the barrier to entry for
> contributions skyrocket.
>

That seems like a bit of an exaggeration. Yes, it requires you to 
install a little extra software, but the end result is a much more 
manageable, human-friendly, and scalable review/audit system than GitHub.

-- 
Alex Rønne Petersen
alex@lycus.org
http://lycus.org
November 14, 2012
Re: [RFC] A huge problem with Github diff
On 11/14/12 12:36 PM, Andrej Mitrovic wrote:
> On 11/14/12, Alex Rønne Petersen<alex@lycus.org>  wrote:
>> Or we could switch to Phabricator for our entire review process which
>> has an absolutely awesome side-by-side diff and is generally a fantastic
>> tool for distributed-style software projects.
>>
>> See my email to dmd-internals:
>> http://lists.puremagic.com/pipermail/dmd-internals/2012-October/004900.html
>
> I don't see what's awesome about it

Everything? :o)

Andrei
November 15, 2012
Re: [RFC] A huge problem with Github diff
Andrei Alexandrescu wrote:
> On 11/14/12 12:36 PM, Andrej Mitrovic wrote:
>> On 11/14/12, Alex Rønne Petersen<alex@lycus.org>  wrote:
>>> Or we could switch to Phabricator for our entire review process which
>>> has an absolutely awesome side-by-side diff and is generally a fantastic
>>> tool for distributed-style software projects.
>>>
>>> See my email to dmd-internals:
>>> http://lists.puremagic.com/pipermail/dmd-internals/2012-
October/004900.html
>>
>> I don't see what's awesome about it
> 
> Everything? :o)

Yes, from the featurelist Phabricator looks pretty awesome. And I'm 
suffering again about an interesting piece of software written in the 
language of my nightmares: PHP

Of course that's only my personal windmill I'm fighting. I just wanted to 
mention Gerrit Code Review: 
http://en.wikipedia.org/wiki/Gerrit_%28software%29

I'm in the process of packaging Gerrit for Debian, but this won't be ready 
before 2013. You can of course install Gerrit with upstreams .war file.

Regards, Thomas Koch
November 15, 2012
Re: [RFC] A huge problem with Github diff
On 15-11-2012 08:35, Thomas Koch wrote:
> Andrei Alexandrescu wrote:
>> On 11/14/12 12:36 PM, Andrej Mitrovic wrote:
>>> On 11/14/12, Alex Rønne Petersen<alex@lycus.org>  wrote:
>>>> Or we could switch to Phabricator for our entire review process which
>>>> has an absolutely awesome side-by-side diff and is generally a fantastic
>>>> tool for distributed-style software projects.
>>>>
>>>> See my email to dmd-internals:
>>>> http://lists.puremagic.com/pipermail/dmd-internals/2012-
> October/004900.html
>>>
>>> I don't see what's awesome about it
>>
>> Everything? :o)
>
> Yes, from the featurelist Phabricator looks pretty awesome. And I'm
> suffering again about an interesting piece of software written in the
> language of my nightmares: PHP
>
> Of course that's only my personal windmill I'm fighting. I just wanted to
> mention Gerrit Code Review:
> http://en.wikipedia.org/wiki/Gerrit_%28software%29
>
> I'm in the process of packaging Gerrit for Debian, but this won't be ready
> before 2013. You can of course install Gerrit with upstreams .war file.
>
> Regards, Thomas Koch
>

Pick your poison: PHP or Java. ;)

*flees*

-- 
Alex Rønne Petersen
alex@lycus.org
http://lycus.org
November 20, 2012
Re: [OT] [RFC] A huge problem with Github diff
14.11.2012 19:27, Denis Shelomovskij пишет:
> P.S.
> Looks like Github's owners doesn't care at all about current users, only
> abut needless features and GUI glance to involve new ones because
> otherwise I have no explanation of this sad situation.

OK, probably Github isn't that bad as it helps some single Japanese:

https://github.com/norinori2222/boyfriend_require/blob/master/README-en.md

But it's still not for programmers...

-- 
Денис В. Шеломовский
Denis V. Shelomovskij
November 20, 2012
Re: [RFC] A huge problem with Github diff
On 11/14/12, Alex Rønne Petersen <alex@lycus.org> wrote:
> You need to manually configure your monospaced font in Phabricator in
> your display preferences.

I did again and using latest Chrome. I can set font settings from the
the code diff via View Options -> Configure Editor, but no matter what
font I type in and click save it doesn't change the diff font.

Here's what the diff looks like: http://i.imgur.com/TGArz.png

That font is Arial, and it stays that way no matter what I put in the
font settings. And in another view I a different font is rendered:
http://i.imgur.com/RClAS.png

Might just be a bug. Btw, what does "Clowncopterize" and "Cook the
books" mean? I hate software that tries to act cute. It also doesn't
have a good folder tree view, files and folders are intermixed. But
maybe there's a setting for this somewhere..

Anyway all of that is nitpicking, I don't want to be negative towards
this software if it would actually make us review and merge pulls
faster. SVN->Github was a win, maybe this would be one too.. I have no
experience using Phabricator so I don't know. From a first look it
seemed complicated compared to Github, maybe with time it would grow
on me.
Next ›   Last »
1 2
Top | Discussion index | About this forum | D home