I am interested in contributing to D on GitHub, and was wondering if there is a minimum or preferabe minimum size of a pull request; e.g. I woukd like to work on increasing code coverage, and am wondering if a pull request with one additional line of code, e.g. one assert () in a unittest block, would be considered not worth the time to consider as a PR?

On 31/01/2017 11:36 PM, Jason Schroeder wrote:
> I am interested in contributing to D on GitHub, and was wondering if
> there is a minimum or preferabe minimum size of a pull request; e.g. I
> woukd like to work on increasing code coverage, and am wondering if a
> pull request with one additional line of code, e.g. one assert () in a
> unittest block, would be considered not worth the time to consider as a PR?

Don't worry about size, just do what adds value.

On Tuesday, 31 January 2017 at 10:42:41 UTC, rikki cattermole wrote:
> On 31/01/2017 11:36 PM, Jason Schroeder wrote:
>> I am interested in contributing to D on GitHub, and was wondering if
>> there is a minimum or preferabe minimum size of a pull request; e.g. I
>> woukd like to work on increasing code coverage, and am wondering if a
>> pull request with one additional line of code, e.g. one assert () in a
>> unittest block, would be considered not worth the time to consider as a PR?
>
> Don't worry about size, just do what adds value.

Thanks for the response, will do.

On 2017-01-31 11:36, Jason Schroeder wrote:
> I am interested in contributing to D on GitHub, and was wondering if
> there is a minimum or preferabe minimum size of a pull request; e.g. I
> woukd like to work on increasing code coverage, and am wondering if a
> pull request with one additional line of code, e.g. one assert () in a
> unittest block, would be considered not worth the time to consider as a PR?

The smaller PR the better :). There's more of an issue if the PR is too big. But adding one assert to one unit test block in ten different PR's might not be appropriate.

-- 
/Jacob Carlborg