March 21
On Wednesday, 20 March 2019 at 22:11:00 UTC, Mike Franklin wrote:
> On Wednesday, 20 March 2019 at 21:58:46 UTC, sighoya wrote:
>
>> How can I help if I'm not the one creating the PR?
>
> It needs someone willing to adopt the PR and work with reviewers to get it across the finish line.  If you've never worked on DMD before, cloning the DMD, druntime, Phobos, etc. and learning how to build the compiler and run the test suite locally is the first step.
>
> Mike

So I can become a reviewer only, but how can I merge additions requested by reviewers, this can only be done by the PR proposer, right?
March 21
On Thursday, 21 March 2019 at 07:08:41 UTC, sighoya wrote:

> So I can become a reviewer only, but how can I propose changes to be merged into the PR proposer's branch, do I need to clone his branch and to create a pull request in hope he accept my changes?

Create a new branch, merge the original author's work into your branch, then add your edits, and submit a new PR.  That's what I'd do anyway.

Mike
March 21
On Thursday, 21 March 2019 at 11:17:52 UTC, Mike Franklin wrote:
> Create a new branch, merge the original author's work into your branch, then add your edits, and submit a new PR.  That's what I'd do anyway.
>
> Mike

Glad to hear.
But does it make sense when there is already one pull request open: https://github.com/dlang/dmd/pull/8378 ?
March 21
On Thursday, 21 March 2019 at 11:29:54 UTC, sighoya wrote:
> On Thursday, 21 March 2019 at 11:17:52 UTC, Mike Franklin wrote:
>> Create a new branch, merge the original author's work into your branch, then add your edits, and submit a new PR.  That's what I'd do anyway.
>>
>> Mike
>
> Glad to hear.
> But does it make sense when there is already one pull request open: https://github.com/dlang/dmd/pull/8378 ?

IMO, yes.

Mike
Next ›   Last »
1 2 3 4 5 6 7 8 9