February 15, 2013
On Friday, 15 February 2013 at 09:55:52 UTC, Jacob Carlborg wrote:
> On 2013-02-15 09:45, Sebastian Graf wrote:
>
>> I'd like to contribute something... Is there anything simple to
>> begin with?
>
> Could you first create a list of what you want more specifically to do/change to have it more D like.
That was actually not related to the D-ifying part rather than general points to help you with that project.
I have to say that I'm not at all familiar with the API right now, so the only specific point for improvement on my side is usage of D properties.

How did you generate the port? Was there a Java-D converter involved and are there any ways to incoporate changes into the process?
February 15, 2013
On 2013-02-15 12:39, Sebastian Graf wrote:

> That was actually not related to the D-ifying part rather than general
> points to help you with that project.
> I have to say that I'm not at all familiar with the API right now, so
> the only specific point for improvement on my side is usage of D
> properties.

In general this is what's need to be done:

* Port snippets and make sure existing ones work
* Port later versions of SWT
* Port to 64bit
* Port the SWT test suite
* In general finding and fixing bugs

> How did you generate the port? Was there a Java-D converter involved and
> are there any ways to incoporate changes into the process?

It's a manual port. We tried to use a tool at one point but it didn't work very well. To much of the Java API needed to be ported.

-- 
/Jacob Carlborg
February 15, 2013
On Friday, 15 February 2013 at 12:04:25 UTC, Jacob Carlborg wrote:
> In general this is what's need to be done:
>
> * Port snippets and make sure existing ones work
> * Port later versions of SWT
> * Port to 64bit
> * Port the SWT test suite
> * In general finding and fixing bugs

I'd like to give the test suite a shot. Which branch of SWT's git repository should I port? One of the 3.4 versions, 4.2 or even the 4.3 integration branch while of course verifying that all tests pass?
February 15, 2013
On Friday, 15 February 2013 at 18:41:42 UTC, Sebastian Graf wrote:
>
> I'd like to give the test suite a shot. Which branch of SWT's git repository should I port? One of the 3.4 versions, 4.2 or even the 4.3 integration branch while of course verifying that all tests pass?

And then again, which test framework should I use?
Since SWT uses JUnit, DUnit would make sense, depending on its maturity. Of course we are using D here, so your rspec unittest sugar would fit even better from my POV.
This is all just based on a quick search.
February 15, 2013
On 2013-02-15 19:41, Sebastian Graf wrote:

> I'd like to give the test suite a shot. Which branch of SWT's git
> repository should I port? One of the 3.4 versions, 4.2 or even the 4.3
> integration branch while of course verifying that all tests pass?

You should use the tag that the rest of the code is based on. That would be 3.449. The version is located at:

https://github.com/d-widget-toolkit/org.eclipse.swt.win32.win32.x86/blob/master/src/org/eclipse/swt/internal/Library.d

Pick the closest tag.

-- 
/Jacob Carlborg
February 15, 2013
On 2013-02-15 20:05, Sebastian Graf wrote:

> And then again, which test framework should I use?
> Since SWT uses JUnit, DUnit would make sense, depending on its maturity.
> Of course we are using D here, so your rspec unittest sugar would fit
> even better from my POV.
> This is all just based on a quick search.

Preferably the code should look as close to the original code as possible, so I guess that means something that looks like JUnit.

-- 
/Jacob Carlborg
February 16, 2013
On 2013-02-15 22:44, Jacob Carlborg wrote:

> You should use the tag that the rest of the code is based on. That would
> be 3.449. The version is located at:

There is a tag called "v3449", there are also tags "v3449a" - "v3449d". I'm not sure which to pick.

-- 
/Jacob Carlborg
February 16, 2013
On Saturday, 16 February 2013 at 12:57:30 UTC, Jacob Carlborg wrote:
>
> There is a tag called "v3449", there are also tags "v3449a" - "v3449d". I'm not sure which to pick.

Do I have to stay D1 compliant with the test suite? This would mean I have to port DUnit too...
February 16, 2013
On 2013-02-16 20:21, Sebastian Graf wrote:

> Do I have to stay D1 compliant with the test suite? This would mean I
> have to port DUnit too...

I don't want anyone to bend over backwards to stay compatible with D1. But as long as there is no big issue in staying compilable I would like to us to stay compatible. One or two string mixins is not a big issue but if it will require significant work we can drop the D1 support.

-- 
/Jacob Carlborg
1 2
Next ›   Last »