Original library: http://code.dlang.org/packages/unit-threaded
PR: https://github.com/D-Programming-Language/phobos/pull/3207

It's my first Phobos PR, I tried reading the wiki and doing what's required but bear with me if I've screwed up somehow.

I wasn't sure whether or not to split the PR. In the end I just took the existing library, edited it a lot and got it ready for review.

Unit test blocks can be named with @Name. They execute in parallel by default but that's only if the default runner is used.

Atila

On 2015-04-20 15:28, Atila Neves wrote:
> Original library: http://code.dlang.org/packages/unit-threaded
> PR: https://github.com/D-Programming-Language/phobos/pull/3207
>
> It's my first Phobos PR, I tried reading the wiki and doing what's
> required but bear with me if I've screwed up somehow.

Any new module must go through the review queue [1]. Ask here in the newsgroup for a review on the code. Generated documetnation and code should be available for the module. A review manager will volunteer to manage the review. When a module has been approved, first then should a pull request be created.

[1] http://wiki.dlang.org/Review_Queue

-- 
/Jacob Carlborg

On Monday, 20 April 2015 at 13:50:59 UTC, Jacob Carlborg wrote:
> On 2015-04-20 15:28, Atila Neves wrote:
>> Original library: http://code.dlang.org/packages/unit-threaded
>> PR: https://github.com/D-Programming-Language/phobos/pull/3207
>>
>> It's my first Phobos PR, I tried reading the wiki and doing what's
>> required but bear with me if I've screwed up somehow.
>
> Any new module must go through the review queue [1]. Ask here in the newsgroup for a review on the code. Generated documetnation and code should be available for the module. A review manager will volunteer to manage the review. When a module has been approved, first then should a pull request be created.
>
> [1] http://wiki.dlang.org/Review_Queue

I saw links to PRs past with generated docs but have/had no
idea how to get a similar result. Besides the html make target,
what is it a person has to do exactly? I'm going to edit the wiki
with this information as well.

Atila

On 2015-04-20 16:29, Atila Neves wrote:

> I saw links to PRs past with generated docs but have/had no
> idea how to get a similar result. Besides the html make target,
> what is it a person has to do exactly? I'm going to edit the wiki
> with this information as well.

Some developer use Ddox [1], some use the same way as Phobos uses. I think it's enough to add you're files to Phobos (including the makefiles) and the generate the documentation using "make" in the dlang.org repository.

[1] https://github.com/rejectedsoftware/ddox

-- 
/Jacob Carlborg

On Monday, 20 April 2015 at 14:29:33 UTC, Atila Neves wrote:
> I saw links to PRs past with generated docs but have/had no
> idea how to get a similar result. Besides the html make target,
> what is it a person has to do exactly? I'm going to edit the wiki

http://wiki.dlang.org/Building_DMD#Building_the_Docs

On Tuesday, 21 April 2015 at 08:17:37 UTC, Robert burner Schadek wrote:
> On Monday, 20 April 2015 at 14:29:33 UTC, Atila Neves wrote:
>> I saw links to PRs past with generated docs but have/had no
>> idea how to get a similar result. Besides the html make target,
>> what is it a person has to do exactly? I'm going to edit the wiki
>
> http://wiki.dlang.org/Building_DMD#Building_the_Docs

This part I'd figured out; it's the getting it online for others to see (and the need to do this as part of the PR) I had troubles with.

I did a lot of google searches for "site:dlang.org std.experimental.logger" ;)

Atila

On Tuesday, 21 April 2015 at 13:18:59 UTC, Atila Neves wrote:
>
> This part I'd figured out; it's the getting it online for others to see (and the need to do this as part of the PR) I had troubles with.

I did use "github pages" https://pages.github.com/

On 2015-04-21 15:56, Robert burner Schadek wrote:

> I did use "github pages" https://pages.github.com/

I have used dropbox.

-- 
/Jacob Carlborg

I think I've addressed all comments now, except for Robert's one on whether or not multi-threading should be on by default. Also, after much toiling I've managed to get the docs up here:

http://atilaneves.github.io/phobos/phobos/std_experimental_testing.html

It really should be a lot easier to generate the docs. Anyway, please give it a look and destroy away.

Atila

On Monday, 20 April 2015 at 13:28:30 UTC, Atila Neves wrote:
> Original library: http://code.dlang.org/packages/unit-threaded
> PR: https://github.com/D-Programming-Language/phobos/pull/3207
>
> It's my first Phobos PR, I tried reading the wiki and doing what's required but bear with me if I've screwed up somehow.
>
> I wasn't sure whether or not to split the PR. In the end I just took the existing library, edited it a lot and got it ready for review.
>
> Unit test blocks can be named with @Name. They execute in parallel by default but that's only if the default runner is used.
>
> Atila

On 2015-06-01 18:38, Atila Neves wrote:
> I think I've addressed all comments now, except for Robert's one on
> whether or not multi-threading should be on by default. Also, after much
> toiling I've managed to get the docs up here:
>
> http://atilaneves.github.io/phobos/phobos/std_experimental_testing.html
>
> It really should be a lot easier to generate the docs. Anyway, please
> give it a look and destroy away.

I would like to have some more documentation, some more examples how to use this.

I think all UDA's should start with a lowercase character.

-- 
/Jacob Carlborg