November 28
On Saturday, 27 November 2021 at 21:37:06 UTC, bachmeier wrote:
>
> That must have been something different. I added a comment on the issue that this is a recent regression, introduced in 2.082.1. It worked correctly before that release.

Looks like an ImportC related change??

lexer.d  -> private TOK number(Token* t)

-----
case '7':
    base = 8;
    break;
case '8':
case '9':
    if (Ccompile)
        error("octal digit expected, not `%c`", c);
    base = 8;
    break;
case 'x':
-----

November 28

On Sunday, 28 November 2021 at 00:09:50 UTC, forkit wrote:

>

On Saturday, 27 November 2021 at 21:37:06 UTC, bachmeier wrote:

>

That must have been something different. I added a comment on the issue that this is a recent regression, introduced in 2.082.1. It worked correctly before that release.

Looks like an ImportC related change??

lexer.d -> private TOK number(Token* t)

>

case '7':
base = 8;
break;
case '8':
case '9':
if (Ccompile)
error("octal digit expected, not %c", c);
base = 8;
break;
case 'x':

Now I'm confused, because AFAICT, that's the only place the compiler will give you that error. Yet you get that error message in D code:

https://run.dlang.io/is/f2F2YD

Does that mean everything is treated as ImportC? If so, it shouldn't:

    // For ImportC
    bool Ccompile;              /// true if compiling ImportC
November 28

On 11/27/21 8:23 PM, bachmeier wrote:

>

Now I'm confused, because AFAICT, that's the only place the compiler will give you that error. Yet you get that error message in D code:

https://run.dlang.io/is/f2F2YD

run.dlang.io is on 2.097.0, which does not have ImportC (always useful to use --version on run.dlang.io to see what version is running).

The code that prints the same error for 2.097.0 is here: https://github.com/dlang/dmd/blob/c436df7580be08481386e13da41c08e91f46b07f/src/dmd/lexer.d#L1990

-Steve

November 28
On Sunday, 28 November 2021 at 22:03:10 UTC, Steven Schveighoffer wrote:
> On 11/27/21 8:23 PM, bachmeier wrote:
>
>> 
>> Now I'm confused, because AFAICT, that's the only place the compiler will give you that error. Yet you get that error message in D code:
>> 
>> https://run.dlang.io/is/f2F2YD
>
> run.dlang.io is on 2.097.0, which does not have ImportC (always useful to use --version on run.dlang.io to see what version is running).
>
> The code that prints the same error for 2.097.0 is here: https://github.com/dlang/dmd/blob/c436df7580be08481386e13da41c08e91f46b07f/src/dmd/lexer.d#L1990
>
> -Steve

It 'appears' that this commit (24th May 2021) caused this issue (see link below). Presumably, only those versions after this commit will be affected.

https://github.com/dlang/dmd/commit/790b1268128f10878f9b782fea8f2e14da203759#diff-6204b7c3e9bc498b31aac8499c84b946d9d1f5a90858dd7522630a8a31cf5938
November 28

On 11/28/21 5:10 PM, forkit wrote:

>

It 'appears' that this commit (24th May 2021) caused this issue (see link below). Presumably, only those versions after this commit will be affected.

https://github.com/dlang/dmd/commit/790b1268128f10878f9b782fea8f2e14da203759#diff-6204b7c3e9bc498b31aac8499c84b946d9d1f5a90858dd7522630a8a31cf5938

There are 2 related problems:

  1. The D compiler does not accept decimals like 08.5 but the grammar does.
  2. The ImportC compiler does not accept decimals like 08.5 but C11 allows it.

Problem 1 existed long before problem 2 (which was only recently added). The code that checks for ImportC mode to print the error is kind of a red herring -- if that wasn't there, it still would error out when it reached the second check (which is still there).

-Steve

November 29

On Sunday, 28 November 2021 at 22:03:10 UTC, Steven Schveighoffer wrote:

>

[..]
run.dlang.io is on 2.097.0, which does not have ImportC (always useful to use --version on run.dlang.io to see what version is running).
[..]

Should be fixed now. The daily schedule workflow (which is in charge of pushing new compiler releases to Docker Hub and ultimately updating https://run.dlang.io / https://tour.dlang.org) has actually been working consistently well except for the minor detail of pushing the new image :D

The issue was that we were only pushing the image on push GH events (when a commit is merged in master), and not on schedule events.

November 29

On Monday, 29 November 2021 at 15:11:59 UTC, Petar Kirov [ZombineDev] wrote:

>

On Sunday, 28 November 2021 at 22:03:10 UTC, Steven Schveighoffer wrote:

>

[...]

Should be fixed now. The daily schedule workflow (which is in charge of pushing new compiler releases to Docker Hub and ultimately updating https://run.dlang.io / https://tour.dlang.org) has actually been working consistently well except for the minor detail of pushing the new image :D

The issue was that we were only pushing the image on push GH events (when a commit is merged in master), and not on schedule events.

Cool, btw do you know what the problem is with running all dmd versions on run.dlang.io?

November 29

On Monday, 29 November 2021 at 15:20:13 UTC, Imperatorn wrote:

>

On Monday, 29 November 2021 at 15:11:59 UTC, Petar Kirov [ZombineDev] wrote:

>

[...]

Cool, btw do you know what the problem is with running all dmd versions on run.dlang.io?

https://github.com/dlang-tour/core/issues/767

Unfortunately, I haven't had the time to fix that yet.

November 29

On Monday, 29 November 2021 at 15:23:47 UTC, Petar Kirov [ZombineDev] wrote:

>

On Monday, 29 November 2021 at 15:20:13 UTC, Imperatorn wrote:

>

On Monday, 29 November 2021 at 15:11:59 UTC, Petar Kirov [ZombineDev] wrote:

>

[...]

Cool, btw do you know what the problem is with running all dmd versions on run.dlang.io?

https://github.com/dlang-tour/core/issues/767

Unfortunately, I haven't had the time to fix that yet.

"All dmd compilers" is working again: https://run.dlang.io/is/t7Wz8N

November 29

On Monday, 29 November 2021 at 15:23:47 UTC, Petar Kirov [ZombineDev] wrote:

>

On Monday, 29 November 2021 at 15:20:13 UTC, Imperatorn wrote:

>

On Monday, 29 November 2021 at 15:11:59 UTC, Petar Kirov [ZombineDev] wrote:

>

[...]

Cool, btw do you know what the problem is with running all dmd versions on run.dlang.io?

https://github.com/dlang-tour/core/issues/767

Unfortunately, I haven't had the time to fix that yet.

Np, just wondering ☀️

Next ›   Last »
1 2