July 29, 2014 Re: New Github Issues | ||||
---|---|---|---|---|
| ||||
Posted in reply to Daniel Murphy | On Tuesday, 29 July 2014 at 16:30:27 UTC, Daniel Murphy wrote: > > Yeah. It would be easy enough to automatically add a 'merged' or 'unmerged' tag to all closed pulls in necessary. I can't see a way to search for pulls _without_ a certain label unfortunately. If you look at the link I posted: https://help.github.com/articles/searching-issues#is I believe the merged vs. unmerged functionality is supposed to be built in. |
July 29, 2014 Re: New Github Issues | ||||
---|---|---|---|---|
| ||||
Posted in reply to Dicebot | On Tuesday, 29 July 2014 at 10:42:24 UTC, Dicebot wrote:
> [...]
> I went ahead and have added few labels for Phobos (https://github.com/D-Programming-Language/phobos/labels):
>
> "blocked (awaits decision)" == "Andrei-blocked" but named a bit more generic just in case
> "blocked by dependency" == depends on some other pull request in dmd / druntime
> "needs work" == pull request author have not responded to review comments for some time
> "needs review" == pull request in a good shape but needs more reviewer input before merging
>
> If it makes sense probably worth making Phobos mail list announcement for all maintainers.
Good start. The blocked ones are kind of long which is a slight problem because Github truncates them in the Pull Request list. Maybe rename them to "awaits decision" and "awaits dependency". I think "await" implies they are blocked fairly well.
|
July 31, 2014 Re: New Github Issues | ||||
---|---|---|---|---|
| ||||
Posted in reply to Brad Anderson | On Tuesday, 29 July 2014 at 17:06:55 UTC, Brad Anderson wrote:
> Good start. The blocked ones are kind of long which is a slight problem because Github truncates them in the Pull Request list. Maybe rename them to "awaits decision" and "awaits dependency". I think "await" implies they are blocked fairly well.
Yep, tweaked a bit to fit without truncation.
I am slowly going through least recently updated pull requests and adding those labels.
|
Copyright © 1999-2021 by the D Language Foundation