Thread overview | ||||||
---|---|---|---|---|---|---|
|
January 16, 2012 [D-runtime] [D-Programming-Language/druntime] 83d59d: temporarily disable failing buggy core.time tests ... | ||||
---|---|---|---|---|
| ||||
Branch: refs/heads/master Home: https://github.com/D-Programming-Language/druntime Commit: 83d59d852c4480ec958caa1d537e92344f028ef7 https://github.com/D-Programming-Language/druntime/commit/83d59d852c4480ec958caa1d537e92344f028ef7 Author: Brad Roberts <braddr at puremagic.com> Date: 2012-01-16 (Mon, 16 Jan 2012) Changed paths: M src/core/time.d Log Message: ----------- temporarily disable failing buggy core.time tests until they're fixed |
January 16, 2012 [D-runtime] [D-Programming-Language/druntime] 83d59d: temporarily disable failing buggy core.time tests ... | ||||
---|---|---|---|---|
| ||||
Posted in reply to GitHub | On Monday, January 16, 2012 16:01:12 GitHub wrote:
> Branch: refs/heads/master
> Home: https://github.com/D-Programming-Language/druntime
> Commit: 83d59d852c4480ec958caa1d537e92344f028ef7
>
> https://github.com/D-Programming-Language/druntime/commit/83d59d852c4480ec9 58caa1d537e92344f028ef7 Author: Brad Roberts <braddr at puremagic.com> Date: 2012-01-16 (Mon, 16 Jan 2012)
>
> Changed paths:
> M src/core/time.d
>
> Log Message:
> -----------
> temporarily disable failing buggy core.time tests until they're fixed
Did Dawg's changes not fix the problem? Or is this a new one?
- Jonathan M Davis
|
January 17, 2012 [D-runtime] [D-Programming-Language/druntime] 83d59d: temporarily disable failing buggy core.time tests ... | ||||
---|---|---|---|---|
| ||||
Posted in reply to Jonathan M Davis | On Tue, 17 Jan 2012 01:16:29 +0100, Jonathan M Davis <jmdavisProg at gmx.com> wrote:
> On Monday, January 16, 2012 16:01:12 GitHub wrote:
>> Branch: refs/heads/master
>> Home: https://github.com/D-Programming-Language/druntime
>> Commit: 83d59d852c4480ec958caa1d537e92344f028ef7
>>
>> https://github.com/D-Programming-Language/druntime/commit/83d59d852c4480ec9 58caa1d537e92344f028ef7 Author: Brad Roberts <braddr at puremagic.com> Date: 2012-01-16 (Mon, 16 Jan 2012)
>>
>> Changed paths:
>> M src/core/time.d
>>
>> Log Message:
>> -----------
>> temporarily disable failing buggy core.time tests until they're fixed
>
> Did Dawg's changes not fix the problem? Or is this a new one?
>
> - Jonathan M Davis
> _______________________________________________
> D-runtime mailing list
> D-runtime at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/d-runtime
It confused the overloading of abs in another unittest in std.file because the compiler tried to use the added private abs function.
|
January 16, 2012 [D-runtime] [D-Programming-Language/druntime] 83d59d: temporarily disable failing buggy core.time tests ... | ||||
---|---|---|---|---|
| ||||
Posted in reply to Martin Nowak | On Tuesday, January 17, 2012 02:14:16 Martin Nowak wrote:
> On Tue, 17 Jan 2012 01:16:29 +0100, Jonathan M Davis <jmdavisProg at gmx.com>
>
> wrote:
> > On Monday, January 16, 2012 16:01:12 GitHub wrote:
> >> Branch: refs/heads/master
> >> Home: https://github.com/D-Programming-Language/druntime
> >> Commit: 83d59d852c4480ec958caa1d537e92344f028ef7
> >>
> >> https://github.com/D-Programming-Language/druntime/commit/83d59d852c44
> >> 80ec9 58caa1d537e92344f028ef7 Author: Brad Roberts
> >> <braddr at puremagic.com> Date: 2012-01-16 (Mon, 16 Jan 2012)
> >>
> >> Changed paths:
> >> M src/core/time.d
> >>
> >> Log Message:
> >> -----------
> >> temporarily disable failing buggy core.time tests until they're fixed
> >
> > Did Dawg's changes not fix the problem? Or is this a new one?
> >
> > - Jonathan M Davis
> > _______________________________________________
> > D-runtime mailing list
> > D-runtime at puremagic.com
> > http://lists.puremagic.com/mailman/listinfo/d-runtime
>
> It confused the overloading of abs in another unittest in std.file because the compiler tried to use the added private abs function.
Either std.datetime's abs needs to be moved to core.time and adjusted appropriately (it's in std.datetime, because it uses std.math.abs, which obviously won't work in core.time), or core.time's abs function needs to be renamed so that it doesn't clash. As it stands, the abs in core.time will break user code. Unfortunately, I forgot about that issue when I merged it in.
- Jonathan M Davis
|
Copyright © 1999-2021 by the D Language Foundation