Branch: refs/heads/master
Home:   https://github.com/D-Programming-Language/phobos

Commit: 8b2ff4c0e9b64cf0d61d031438204d0fe126a880
    https://github.com/D-Programming-Language/phobos/commit/8b2ff4c0e9b64cf0d61d031438204d0fe126a880
Author: Don Clugston <dclugston at googlemail.com>
Date:   2011-05-04 (Wed, 04 May 2011)

Changed paths:
  M std/math.d

Log Message:
-----------
Revert "Merge pull request #24 from braddr/intrinsics."

This reverts commit 8fd2c0445495058ce51922a20b0c276c507e7ee3, reversing changes made to d061f13d34a35a16c4d51df0ae985d1b28eb4ef9.

This change exposed irrelvant DMD compiler implementation details, with no benefit (and also broke the build).

I still disagree with your logic.  The entire point of the runtime is to provide and encapsulate the boundary between the compiler and higher level libraries.  Intrinsics are inherently part of that boundary.

I do agree with getting the tree back to a buildable state though.

On 5/4/2011 7:48 AM, noreply at github.com wrote:
> Branch: refs/heads/master
> Home:   https://github.com/D-Programming-Language/phobos
> 
> Commit: 8b2ff4c0e9b64cf0d61d031438204d0fe126a880
>     https://github.com/D-Programming-Language/phobos/commit/8b2ff4c0e9b64cf0d61d031438204d0fe126a880
> Author: Don Clugston <dclugston at googlemail.com>
> Date:   2011-05-04 (Wed, 04 May 2011)
> 
> Changed paths:
>   M std/math.d
> 
> Log Message:
> -----------
> Revert "Merge pull request #24 from braddr/intrinsics."
> 
> This reverts commit 8fd2c0445495058ce51922a20b0c276c507e7ee3, reversing changes made to d061f13d34a35a16c4d51df0ae985d1b28eb4ef9.
> 
> This change exposed irrelvant DMD compiler implementation details, with no benefit (and also broke the build).
> 

Phobos still fails to build?

std.intrinsic has been moved. Please import core.bitop instead.
std\internal\math\biguintcore.d(1250): Error: import bsr not found
std\internal\math\biguintcore.d(1250): Error: alias
std.internal.math.biguintcore.bsr recursive alia
s declaration

On 5/4/2011 7:48 AM, noreply at github.com wrote:
> Branch: refs/heads/master
> Home:   https://github.com/D-Programming-Language/phobos
>
> Commit: 8b2ff4c0e9b64cf0d61d031438204d0fe126a880
>      https://github.com/D-Programming-Language/phobos/commit/8b2ff4c0e9b64cf0d61d031438204d0fe126a880
> Author: Don Clugston<dclugston at googlemail.com>
> Date:   2011-05-04 (Wed, 04 May 2011)
>
> Changed paths:
>    M std/math.d
>
> Log Message:
> -----------
> Revert "Merge pull request #24 from braddr/intrinsics."
>
> This reverts commit 8fd2c0445495058ce51922a20b0c276c507e7ee3, reversing changes made to d061f13d34a35a16c4d51df0ae985d1b28eb4ef9.
>
> This change exposed irrelvant DMD compiler implementation details, with no benefit (and also broke the build).
>

You're first stop on these sorts of questions should likely be the auto-tester... it's green, so it's a problem on your end almost guaranteed.

On Wed, 4 May 2011, Walter Bright wrote:

> Phobos still fails to build?
> 
> std.intrinsic has been moved. Please import core.bitop instead.
> std\internal\math\biguintcore.d(1250): Error: import bsr not found
> std\internal\math\biguintcore.d(1250): Error: alias
> std.internal.math.biguintcore.bsr recursive alia
> s declaration
> 
> On 5/4/2011 7:48 AM, noreply at github.com wrote:
> > Branch: refs/heads/master
> > Home:   https://github.com/D-Programming-Language/phobos
> > 
> > Commit: 8b2ff4c0e9b64cf0d61d031438204d0fe126a880
> >      https://github.com/D-Programming-Language/phobos/commit/8b2ff4c0e9b64cf0d61d031438204d0fe126a880
> > Author: Don Clugston<dclugston at googlemail.com>
> > Date:   2011-05-04 (Wed, 04 May 2011)
> > 
> > Changed paths:
> >    M std/math.d
> > 
> > Log Message:
> > -----------
> > Revert "Merge pull request #24 from braddr/intrinsics."
> > 
> > This reverts commit 8fd2c0445495058ce51922a20b0c276c507e7ee3, reversing changes made to d061f13d34a35a16c4d51df0ae985d1b28eb4ef9.
> > 
> > This change exposed irrelvant DMD compiler implementation details, with no benefit (and also broke the build).
> > 
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
> 

On 4 May 2011 20:11, Brad Roberts <braddr at puremagic.com> wrote:
> I still disagree with your logic. ?The entire point of the runtime is to provide and encapsulate the boundary between the compiler and higher level libraries. ?Intrinsics are inherently part of that boundary.

I don't agree with that -- I really don't like the vague word "boundary".
My view: the runtime contains support code, which is required by the
compiler. So that, if you remove something from the runtime, something
won't work.
This is not true for these intrinsics -- the fact that they are
intrinsics is a compiler-specific optimisation, and nothing more. I do
not believe that functions should be moved out of Phobos just because
some compiler has provides an intrinsic for them.

One thing for sure --- on ANYTHING other than x86 using an x87 CPU,
sin() and cos() will not be intrinsics.

The only reason the bit operation intrinsics are in the runtime is
because the runtime uses them, and we want to have that optimisation
available.
Likewise, the only possible benefit I could see for this, is if the
runtime was to use those functions itself. But it is just as likely to
require non-intrinsic math functions (you can make a reasonable case
that exp() should be in the runtime).