December 05, 2012 [dmd-internals] [D-Programming-Language/dmd] f4718c: fix split usage in d_do_test.d | ||||
---|---|---|---|---|
| ||||
Attachments:
| Branch: refs/heads/master Home: https://github.com/D-Programming-Language/dmd Commit: f4718cedf1cd4511b21ae5b8ede9883cfd2b14d0 https://github.com/D-Programming-Language/dmd/commit/f4718cedf1cd4511b21ae5b8ede9883cfd2b14d0 Author: monarch dodra <monarchdodra@gmail.com> Date: 2012-11-12 (Mon, 12 Nov 2012) Changed paths: M test/d_do_test.d Log Message: ----------- fix split usage in d_do_test.d As mentioned in https://github.com/D-Programming-Language/phobos/pull/934#issuecomment-10282813 The *correct* behavior for `splitter(string, string)` is to create empty tokens when input is empty (or when there are trailing separators or whatnot). My fix was creating a problem here, where a new empty token was being (correctly) generated: http://d.puremagic.com/test-results/pull.ghtml?runid=368596&logid=7 `../src/dmd -m32 -Icompilable -odtest_results/compilable -oftest_results/compilable/99bottles_0.o -c compilable/99bottles.d compilable/` Anyways, the simple fix is to just use the simple string-dedicated `split(string)`, which does not produce empty tokens. Commit: 7910e8d449fb854a9a73b879221a816023c285c9 https://github.com/D-Programming-Language/dmd/commit/7910e8d449fb854a9a73b879221a816023c285c9 Author: Walter Bright <walter@walterbright.com> Date: 2012-12-05 (Wed, 05 Dec 2012) Changed paths: M test/d_do_test.d Log Message: ----------- Merge pull request #1278 from monarchdodra/master Small split(string, string) fix in d_do_test.d Compare: https://github.com/D-Programming-Language/dmd/compare/2f505206d1af...7910e8d449fb |
Copyright © 1999-2021 by the D Language Foundation