July 14, 2014 [D-runtime] [D-Programming-Language/druntime] 3787f9: Fix issue 12958 - core.checkedint.mulu is broken. | ||||
---|---|---|---|---|
| ||||
Attachments:
| Branch: refs/heads/master Home: https://github.com/D-Programming-Language/druntime Commit: 3787f9b79d807631af37a986a8a164a192413a1b https://github.com/D-Programming-Language/druntime/commit/3787f9b79d807631af37a986a8a164a192413a1b Author: David Nadlinger <code@klickverbot.at> Date: 2014-07-13 (Sun, 13 Jul 2014) Changed paths: M src/core/checkedint.d Log Message: ----------- Fix issue 12958 - core.checkedint.mulu is broken. This implements the (uint, uint) case using ulong arithmetic and the (ulong, ulong) case using trial division. See Bugzilla for an ulong implementation by David Bregman that does not require a division. As the functions are expected to be implemented as compiler intrinsics to make use of architecture-specific primitives anyway, the simpler version has been chosen to reduce the potential for bugs, even though it is slower. Commit: 7d2a2ef77fd07796ef1e96ec1ef5fac9016f511d https://github.com/D-Programming-Language/druntime/commit/7d2a2ef77fd07796ef1e96ec1ef5fac9016f511d Author: Walter Bright <walter@walterbright.com> Date: 2014-07-14 (Mon, 14 Jul 2014) Changed paths: M src/core/checkedint.d Log Message: ----------- Merge pull request #890 from klickverbot/fix-checkedint-umul Fix issue 12958 - core.checkedint.mulu is broken. Compare: https://github.com/D-Programming-Language/druntime/compare/7474e953a913...7d2a2ef77fd0 |
Copyright © 1999-2021 by the D Language Foundation